Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 8822014: MIPS: Fixing MathPowHalf on ARM. (Closed)

Created:
9 years ago by kalmard
Modified:
9 years ago
Reviewers:
kisg, Paul Lind, Yang, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fixing MathPowHalf on ARM. Port r10166 (b57f3f1a), r10167 (202eada9) and r10170 (5c5c96da). BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10214

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +15 lines, -4 lines 2 comments Download
M src/mips/lithium-mips.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kalmard
Building and testing v8 on mips also requires the following patches to be landed: http://codereview.chromium.org/8789012/ ...
9 years ago (2011-12-06 16:15:05 UTC) #1
Yang
This seems to be implemented more complicatedly than necessary. Please clarify. http://codereview.chromium.org/8822014/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): ...
9 years ago (2011-12-06 16:21:53 UTC) #2
kalmard
9 years ago (2011-12-08 13:19:26 UTC) #3
http://codereview.chromium.org/8822014/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):

http://codereview.chromium.org/8822014/diff/1/src/mips/lithium-codegen-mips.c...
src/mips/lithium-codegen-mips.cc:3000: 
On 2011/12/06 16:21:53, Yang wrote:
> From what I can see, you don't need to reserve an additional temp register
(and
> change register allocation in lithium-mips.cc) if you can already take
advantage
> of a double_scratch0().
> Or is this double_scratch0() somehow related to kDoubleRegZero?
I generally try to stick close to the ARM version because in my experience it
makes long-term maintenance easier. However if this has a performance impact or
you feel that the code is better the other way, I will obviously change it.
The change is not related to kDoubleRegZero.

Powered by Google App Engine
This is Rietveld 408576698