Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 8821019: Porting Math.pow changes to x64. (Closed)

Created:
9 years ago by Yang
Modified:
9 years ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Porting Math.pow changes to x64. TEST=math-pow.js, regress-397.js Committed: http://code.google.com/p/v8/source/detail?r=10185

Patch Set 1 #

Patch Set 2 : Prettify register names. #

Total comments: 4

Patch Set 3 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -276 lines) Patch
M src/ia32/code-stubs-ia32.cc View 1 2 7 chunks +96 lines, -98 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 1 comment Download
M src/ia32/lithium-ia32.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 1 chunk +250 lines, -128 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +27 lines, -46 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
PTAL. This should essentially be the same as the ia32 version, except that base is ...
9 years ago (2011-12-06 14:47:23 UTC) #1
Yang
Uploaded patch set to change register names.
9 years ago (2011-12-06 16:16:38 UTC) #2
ulan
9 years ago (2011-12-06 17:38:04 UTC) #3
LGTM if the comments are addressed.

http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc#ne...
src/ia32/code-stubs-ia32.cc:2978: 
Moving the empty line before the bind would be better.

http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc#ne...
src/ia32/code-stubs-ia32.cc:3078: __ addsd(double_exponent, double_base);  //
Convert -0 to +0.
addsd(double_base, double_exponent) would allow you to use double_base later.

http://codereview.chromium.org/8821019/diff/10/src/ia32/code-stubs-ia32.cc#ne...
src/ia32/code-stubs-ia32.cc:3112: __ test_b(exponent, 0x5F);  // We check for
all but precision exception.
Assuming that exponent == eax.

http://codereview.chromium.org/8821019/diff/10/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/8821019/diff/10/src/x64/code-stubs-x64.cc#newc...
src/x64/code-stubs-x64.cc:2128: __ addsd(double_exponent, double_base);  //
Convert -0 to +0.
addsd(double_base, double_exponent) would allow you to use double_base later.

http://codereview.chromium.org/8821019/diff/2002/src/ia32/lithium-codegen-ia3...
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/8821019/diff/2002/src/ia32/lithium-codegen-ia3...
src/ia32/lithium-codegen-ia32.cc:2995:
ASSERT(!instr->InputAt(1)->IsDoubleRegister() ||
Don't forget to change the assertions to reflect register changes.

Powered by Google App Engine
This is Rietveld 408576698