Issue 8821005: Revert 113110 - backing out 113015 didn't fix the interactive test bot. Restoring the CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8821005: Revert 113110 - backing out 113015 didn't fix the interactive test bot. Restoring the CL (Closed)

Created:
9 years ago by sail

Modified:
9 years ago

Reviewers:
sail

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 113110 - backing out 113015 didn't fix the interactive test bot. Restoring the CL Revert 113015 - speculative revert to see if this fixes the interactive test breakage Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used. BUG=98716 Review URL: http://codereview.chromium.org/8801002 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/8817007 TBR=sail@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113118

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -59 lines)			Patch
M	chrome/browser/browser_focus_uitest.cc	View	7 chunks	+10 lines, -28 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages