Issue 8801002: Remove OnMessageReceived that was using internal content IPCs...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8801002: Remove OnMessageReceived that was using internal content IPCs... (Closed)

Created:
9 years ago by jam

Modified:
9 years ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113015

Patch Set 1 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -57 lines)			Patch
M	chrome/browser/browser_focus_uitest.cc	View	6 chunks	+8 lines, -26 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages