Issue 8820016: Don't attempt to forward declare StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8820016: Don't attempt to forward declare StringPiece. (Closed)

Created:
9 years ago by erikwright (departed)

Modified:
9 years ago

Reviewers:
brettw

CC:
chromium-reviews, jstritar+watch_chromium.org, cbentzel+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't attempt to forward declare StringPiece. 1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types. 2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'. BUG=87634 R=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114124

Patch Set 1 #

Patch Set 2 : Fix include order. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -22 lines)			Patch
M	base/sys_string_conversions.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/user_script_master.h	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/common/jstemplate_builder.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/net/net_resource_provider.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/static_v8_external_string_resource.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/test/base/v8_unit_test.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	content/shell/shell.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/8820016/2001

9 years ago (2011-12-12 22:48:19 UTC) #3

Change committed as 114124

Expand Messages | Collapse Messages