Issue 8819013: Add UMA metrics to Photo Editor

Issue 8819013: Add UMA metrics to Photo Editor (Closed)

Created:
9 years ago by Vladislav Kaznacheev

Modified:
9 years ago

Reviewers:
dgozman, SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org, Ilya Sherman, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add UMA metrics to Photo Editor BUG=chromium-os:23803 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113221

Patch Set 3 : Better names for some metrics #

Patch Set 4 : Addressed comments #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -104 lines)			Patch
M	chrome/browser/resources/file_manager/js/file_manager.js	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View	1 2 3	7 chunks	+46 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery_demo.html	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/gallery_demo.js	View	1	1 chunk	+19 lines, -29 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_editor.js	View	1 2 3	7 chunks	+28 lines, -8 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_encoder.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_util.js	View	1 2 3	6 chunks	+28 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_view.js	View	1 2 3	5 chunks	+26 lines, -15 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/main.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/metrics.js	View	1 2 3	1 chunk	+42 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

Please review. This patch introduces UMA metrics into the Photo Editor and also simplifies the ...

9 years ago (2011-12-06 11:18:19 UTC) #1

dgozman

LGTM with comments http://codereview.chromium.org/8819013/diff/3001/chrome/browser/resources/file_manager/js/image_editor/gallery.js File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right): http://codereview.chromium.org/8819013/diff/3001/chrome/browser/resources/file_manager/js/image_editor/gallery.js#newcode346 chrome/browser/resources/file_manager/js/image_editor/gallery.js:346: Gallery.FILE_TYPES = ['jpg', 'png', 'gif', 'bmp', ...

9 years ago (2011-12-06 15:45:55 UTC) #2

Vladislav Kaznacheev

Thanks for the review, committing http://codereview.chromium.org/8819013/diff/3001/chrome/browser/resources/file_manager/js/image_editor/gallery.js File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right): http://codereview.chromium.org/8819013/diff/3001/chrome/browser/resources/file_manager/js/image_editor/gallery.js#newcode346 chrome/browser/resources/file_manager/js/image_editor/gallery.js:346: Gallery.FILE_TYPES = ['jpg', 'png', ...

9 years ago (2011-12-06 16:07:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8819013/5002

9 years ago (2011-12-06 16:08:56 UTC) #4

Change committed as 113221

Expand Messages | Collapse Messages