Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome/browser/resources/file_manager/js/file_manager.js

Issue 8819013: Add UMA metrics to Photo Editor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/js/image_editor/gallery.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/file_manager/js/file_manager.js
diff --git a/chrome/browser/resources/file_manager/js/file_manager.js b/chrome/browser/resources/file_manager/js/file_manager.js
index bbf220269178eef97a40603294ff4fecdeccfa02..0a1157c1fe2d50e6c6f0266c732aafbd08efe787 100644
--- a/chrome/browser/resources/file_manager/js/file_manager.js
+++ b/chrome/browser/resources/file_manager/js/file_manager.js
@@ -499,12 +499,12 @@ FileManager.prototype = {
self.filesystem_ = filesystem;
util.installFileErrorToString();
- metrics.recordTime('Load.FileSystem');
+ metrics.recordInterval('Load.FileSystem');
var rootEntries = [];
function onAllRootsFound() {
- metrics.recordTime('Load.Roots');
+ metrics.recordInterval('Load.Roots');
self.rootEntries_ = rootEntries;
onDone();
}
@@ -618,8 +618,8 @@ FileManager.prototype = {
this.refocus();
this.createMetadataProvider_();
- metrics.recordTime('Load.DOM');
- metrics.recordTime('Load.Total');
+ metrics.recordInterval('Load.DOM');
+ metrics.recordInterval('Load.Total');
};
/**
@@ -2368,6 +2368,7 @@ FileManager.prototype = {
galleryFrame.onload = function() {
self.document_.title = str('GALLERY');
+ galleryFrame.contentWindow.ImageUtil.metrics = metrics;
galleryFrame.contentWindow.Gallery.open(
self.currentDirEntry_,
urls,
@@ -3189,9 +3190,9 @@ FileManager.prototype = {
function onReadSome(entries) {
if (entries.length == 0) {
- metrics.recordTime('DirectoryScan');
+ metrics.recordInterval('DirectoryScan');
if (self.currentDirEntry_.fullPath == DOWNLOADS_DIRECTORY) {
- metrics.reportCount("DownloadsCount", self.dataModel_.length);
+ metrics.recordMediumCount("DownloadsCount", self.dataModel_.length);
}
if (self.pendingRescanQueue_.length > 0) {
« no previous file with comments | « no previous file | chrome/browser/resources/file_manager/js/image_editor/gallery.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698