Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 8818012: Remove the AudioManager singleton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
===================================================================
--- content/browser/renderer_host/render_process_host_impl.cc (revision 113173)
+++ content/browser/renderer_host/render_process_host_impl.cc (working copy)
@@ -7,6 +7,10 @@
#include "content/browser/renderer_host/render_process_host_impl.h"
+#if defined(OS_WIN)
+#include <objbase.h> // For CoInitialize/CoUninitialize.
+#endif
+
#include <algorithm>
#include <limits>
#include <vector>
@@ -73,6 +77,7 @@
#include "content/browser/renderer_host/socket_stream_dispatcher_host.h"
#include "content/browser/renderer_host/text_input_client_message_filter.h"
#include "content/browser/resolve_proxy_msg_helper.h"
+#include "content/browser/resource_context.h"
#include "content/browser/speech/speech_input_dispatcher_host.h"
#include "content/browser/trace_message_filter.h"
#include "content/browser/user_metrics.h"
@@ -104,7 +109,6 @@
#include "webkit/plugins/plugin_switches.h"
#if defined(OS_WIN)
-#include <objbase.h>
#include "base/synchronization/waitable_event.h"
#include "content/common/font_cache_dispatcher_win.h"
#endif
@@ -460,55 +464,58 @@
GetBrowserContext()->GetRequestContextForRenderProcess(GetID()),
widget_helper_));
channel_->AddFilter(render_message_filter);
+ content::BrowserContext* browser_context = GetBrowserContext();
+ const content::ResourceContext* resource_context =
+ &browser_context->GetResourceContext();
ResourceMessageFilter* resource_message_filter = new ResourceMessageFilter(
GetID(), content::PROCESS_TYPE_RENDERER,
- &GetBrowserContext()->GetResourceContext(),
- new RendererURLRequestContextSelector(GetBrowserContext(), GetID()),
+ resource_context,
+ new RendererURLRequestContextSelector(browser_context, GetID()),
content::GetContentClient()->browser()->GetResourceDispatcherHost());
channel_->AddFilter(resource_message_filter);
channel_->AddFilter(new AudioInputRendererHost(
Avi (use Gerrit) 2011/12/06 15:22:59 unwrap this and subsequent lines where wrapping is
tommi (sloooow) - chröme 2011/12/06 15:48:21 Done.
- &GetBrowserContext()->GetResourceContext()));
+ resource_context));
+ channel_->AddFilter(new AudioRendererHost(resource_context));
channel_->AddFilter(
- new AudioRendererHost(&GetBrowserContext()->GetResourceContext()));
+ new VideoCaptureHost(resource_context));
channel_->AddFilter(
- new VideoCaptureHost(&GetBrowserContext()->GetResourceContext()));
- channel_->AddFilter(
- new AppCacheDispatcherHost(GetBrowserContext()->GetAppCacheService(),
+ new AppCacheDispatcherHost(browser_context->GetAppCacheService(),
GetID()));
channel_->AddFilter(new ClipboardMessageFilter());
channel_->AddFilter(
new DOMStorageMessageFilter(GetID(),
- GetBrowserContext()->GetWebKitContext()));
+ browser_context->GetWebKitContext()));
channel_->AddFilter(
new IndexedDBDispatcherHost(GetID(),
- GetBrowserContext()->GetWebKitContext()));
+ browser_context->GetWebKitContext()));
channel_->AddFilter(
GeolocationDispatcherHost::New(
- GetID(), GetBrowserContext()->GetGeolocationPermissionContext()));
+ GetID(), browser_context->GetGeolocationPermissionContext()));
channel_->AddFilter(new GpuMessageFilter(GetID(), widget_helper_.get()));
channel_->AddFilter(new media_stream::MediaStreamDispatcherHost(
- &GetBrowserContext()->GetResourceContext(), GetID()));
+ resource_context, GetID()));
channel_->AddFilter(new PepperFileMessageFilter(GetID(),
- GetBrowserContext()));
+ browser_context));
channel_->AddFilter(
- new PepperMessageFilter(&GetBrowserContext()->GetResourceContext()));
+ new PepperMessageFilter(resource_context));
channel_->AddFilter(new speech_input::SpeechInputDispatcherHost(
- GetID(), GetBrowserContext()->GetRequestContext(),
- GetBrowserContext()->GetSpeechInputPreferences()));
+ GetID(), browser_context->GetRequestContext(),
+ browser_context->GetSpeechInputPreferences(),
+ resource_context->audio_manager()));
channel_->AddFilter(
new FileSystemDispatcherHost(
- GetBrowserContext()->GetRequestContext(),
- GetBrowserContext()->GetFileSystemContext()));
+ browser_context->GetRequestContext(),
+ browser_context->GetFileSystemContext()));
channel_->AddFilter(new device_orientation::MessageFilter());
channel_->AddFilter(
new BlobMessageFilter(GetID(),
- GetBrowserContext()->GetBlobStorageContext()));
+ browser_context->GetBlobStorageContext()));
channel_->AddFilter(new FileUtilitiesMessageFilter(GetID()));
channel_->AddFilter(new MimeRegistryMessageFilter());
channel_->AddFilter(new DatabaseMessageFilter(
- GetBrowserContext()->GetDatabaseTracker()));
+ browser_context->GetDatabaseTracker()));
#if defined(OS_MACOSX)
channel_->AddFilter(new TextInputClientMessageFilter(GetID()));
#elif defined(OS_WIN)
@@ -517,28 +524,28 @@
SocketStreamDispatcherHost* socket_stream_dispatcher_host =
new SocketStreamDispatcherHost(
- new RendererURLRequestContextSelector(GetBrowserContext(), GetID()),
- &GetBrowserContext()->GetResourceContext());
+ new RendererURLRequestContextSelector(browser_context, GetID()),
+ resource_context);
channel_->AddFilter(socket_stream_dispatcher_host);
channel_->AddFilter(
new WorkerMessageFilter(
GetID(),
- &GetBrowserContext()->GetResourceContext(),
+ resource_context,
content::GetContentClient()->browser()->GetResourceDispatcherHost(),
base::Bind(&RenderWidgetHelper::GetNextRoutingID,
base::Unretained(widget_helper_.get()))));
#if defined(ENABLE_P2P_APIS)
channel_->AddFilter(new content::P2PSocketDispatcherHost(
- &GetBrowserContext()->GetResourceContext()));
+ resource_context));
#endif
channel_->AddFilter(new TraceMessageFilter());
channel_->AddFilter(new ResolveProxyMsgHelper(
- GetBrowserContext()->GetRequestContextForRenderProcess(GetID())));
+ browser_context->GetRequestContextForRenderProcess(GetID())));
channel_->AddFilter(new QuotaDispatcherHost(
- GetID(), GetBrowserContext()->GetQuotaManager(),
+ GetID(), browser_context->GetQuotaManager(),
content::GetContentClient()->browser()->CreateQuotaPermissionContext()));
channel_->AddFilter(new content::GamepadBrowserMessageFilter(this));
channel_->AddFilter(new ProfilerMessageFilter());

Powered by Google App Engine
This is Rietveld 408576698