Remove the AudioManager singleton.

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
+#if defined(OS_WIN)
+#include <objbase.h>  // For CoInitialize/CoUninitialize.
+#endif
+
 #include <algorithm>
 #include <limits>
 #include <vector>
 
 #if defined(OS_POSIX)
 #include <utility>  // for pair<>
 #endif
 
 #include "base/base_switches.h"
 #include "base/bind.h"
@@ skipping 46 matching lines @@
 #include "content/browser/renderer_host/quota_dispatcher_host.h"
 #include "content/browser/renderer_host/render_message_filter.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/render_view_host_delegate.h"
 #include "content/browser/renderer_host/render_widget_helper.h"
 #include "content/browser/renderer_host/render_widget_host.h"
 #include "content/browser/renderer_host/resource_message_filter.h"
 #include "content/browser/renderer_host/socket_stream_dispatcher_host.h"
 #include "content/browser/renderer_host/text_input_client_message_filter.h"
 #include "content/browser/resolve_proxy_msg_helper.h"
+#include "content/browser/resource_context.h"
 #include "content/browser/speech/speech_input_dispatcher_host.h"
 #include "content/browser/trace_message_filter.h"
 #include "content/browser/user_metrics.h"
 #include "content/browser/webui/web_ui_factory.h"
 #include "content/browser/worker_host/worker_message_filter.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/common/child_process_messages.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "content/public/browser/notification_service.h"
 #include "content/common/resource_messages.h"
@@ skipping 11 matching lines @@
 #include "media/base/media_switches.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/base/ui_base_switches.h"
 #include "ui/gfx/gl/gl_switches.h"
 #include "webkit/fileapi/file_system_path_manager.h"
 #include "webkit/fileapi/sandbox_mount_point_provider.h"
 #include "webkit/glue/resource_type.h"
 #include "webkit/plugins/plugin_switches.h"
 
 #if defined(OS_WIN)
-#include <objbase.h>
 #include "base/synchronization/waitable_event.h"
 #include "content/common/font_cache_dispatcher_win.h"
 #endif
 
 #include "third_party/skia/include/core/SkBitmap.h"
 
 using content::BrowserThread;
 using content::ChildProcessHost;
 using content::ChildProcessHostImpl;
 
@@ skipping 335 matching lines @@
 
 void RenderProcessHostImpl::CreateMessageFilters() {
   scoped_refptr<RenderMessageFilter> render_message_filter(
       new RenderMessageFilter(
           GetID(),
           PluginService::GetInstance(),
           GetBrowserContext(),
           GetBrowserContext()->GetRequestContextForRenderProcess(GetID()),
           widget_helper_));
   channel_->AddFilter(render_message_filter);
+  content::BrowserContext* browser_context = GetBrowserContext();
+  const content::ResourceContext* resource_context =
+      &browser_context->GetResourceContext();
 
   ResourceMessageFilter* resource_message_filter = new ResourceMessageFilter(
       GetID(), content::PROCESS_TYPE_RENDERER,
-      &GetBrowserContext()->GetResourceContext(),
-      new RendererURLRequestContextSelector(GetBrowserContext(), GetID()),
+      resource_context,
+      new RendererURLRequestContextSelector(browser_context, GetID()),
       content::GetContentClient()->browser()->GetResourceDispatcherHost());
 
   channel_->AddFilter(resource_message_filter);
   channel_->AddFilter(new AudioInputRendererHost(

[Avi (use Gerrit), 2011/12/06 15:22:59]

unwrap this and subsequent lines where wrapping is no longer needed

[tommi (sloooow) - chröme, 2011/12/06 15:48:21]

Done.

-      &GetBrowserContext()->GetResourceContext()));
+      resource_context));
+  channel_->AddFilter(new AudioRendererHost(resource_context));
   channel_->AddFilter(
-      new AudioRendererHost(&GetBrowserContext()->GetResourceContext()));
+      new VideoCaptureHost(resource_context));
   channel_->AddFilter(
-      new VideoCaptureHost(&GetBrowserContext()->GetResourceContext()));
-  channel_->AddFilter(
-      new AppCacheDispatcherHost(GetBrowserContext()->GetAppCacheService(),
+      new AppCacheDispatcherHost(browser_context->GetAppCacheService(),
                                  GetID()));
   channel_->AddFilter(new ClipboardMessageFilter());
   channel_->AddFilter(
       new DOMStorageMessageFilter(GetID(),
-                                  GetBrowserContext()->GetWebKitContext()));
+                                  browser_context->GetWebKitContext()));
   channel_->AddFilter(
       new IndexedDBDispatcherHost(GetID(),
-                                  GetBrowserContext()->GetWebKitContext()));
+                                  browser_context->GetWebKitContext()));
   channel_->AddFilter(
       GeolocationDispatcherHost::New(
-          GetID(), GetBrowserContext()->GetGeolocationPermissionContext()));
+          GetID(), browser_context->GetGeolocationPermissionContext()));
   channel_->AddFilter(new GpuMessageFilter(GetID(), widget_helper_.get()));
   channel_->AddFilter(new media_stream::MediaStreamDispatcherHost(
-      &GetBrowserContext()->GetResourceContext(), GetID()));
+      resource_context, GetID()));
   channel_->AddFilter(new PepperFileMessageFilter(GetID(),
-                      GetBrowserContext()));
+                      browser_context));
   channel_->AddFilter(
-      new PepperMessageFilter(&GetBrowserContext()->GetResourceContext()));
+      new PepperMessageFilter(resource_context));
   channel_->AddFilter(new speech_input::SpeechInputDispatcherHost(
-      GetID(), GetBrowserContext()->GetRequestContext(),
-      GetBrowserContext()->GetSpeechInputPreferences()));
+      GetID(), browser_context->GetRequestContext(),
+      browser_context->GetSpeechInputPreferences(),
+      resource_context->audio_manager()));
   channel_->AddFilter(
       new FileSystemDispatcherHost(
-          GetBrowserContext()->GetRequestContext(),
-          GetBrowserContext()->GetFileSystemContext()));
+          browser_context->GetRequestContext(),
+          browser_context->GetFileSystemContext()));
   channel_->AddFilter(new device_orientation::MessageFilter());
   channel_->AddFilter(
       new BlobMessageFilter(GetID(),
-                            GetBrowserContext()->GetBlobStorageContext()));
+                            browser_context->GetBlobStorageContext()));
   channel_->AddFilter(new FileUtilitiesMessageFilter(GetID()));
   channel_->AddFilter(new MimeRegistryMessageFilter());
   channel_->AddFilter(new DatabaseMessageFilter(
-      GetBrowserContext()->GetDatabaseTracker()));
+      browser_context->GetDatabaseTracker()));
 #if defined(OS_MACOSX)
   channel_->AddFilter(new TextInputClientMessageFilter(GetID()));
 #elif defined(OS_WIN)
   channel_->AddFilter(new FontCacheDispatcher());
 #endif
 
   SocketStreamDispatcherHost* socket_stream_dispatcher_host =
       new SocketStreamDispatcherHost(
-          new RendererURLRequestContextSelector(GetBrowserContext(), GetID()),
-          &GetBrowserContext()->GetResourceContext());
+          new RendererURLRequestContextSelector(browser_context, GetID()),
+          resource_context);
   channel_->AddFilter(socket_stream_dispatcher_host);
 
   channel_->AddFilter(
       new WorkerMessageFilter(
           GetID(),
-          &GetBrowserContext()->GetResourceContext(),
+          resource_context,
           content::GetContentClient()->browser()->GetResourceDispatcherHost(),
           base::Bind(&RenderWidgetHelper::GetNextRoutingID,
                      base::Unretained(widget_helper_.get()))));
 
 #if defined(ENABLE_P2P_APIS)
   channel_->AddFilter(new content::P2PSocketDispatcherHost(
-      &GetBrowserContext()->GetResourceContext()));
+      resource_context));
 #endif
 
   channel_->AddFilter(new TraceMessageFilter());
   channel_->AddFilter(new ResolveProxyMsgHelper(
-      GetBrowserContext()->GetRequestContextForRenderProcess(GetID())));
+      browser_context->GetRequestContextForRenderProcess(GetID())));
   channel_->AddFilter(new QuotaDispatcherHost(
-      GetID(), GetBrowserContext()->GetQuotaManager(),
+      GetID(), browser_context->GetQuotaManager(),
       content::GetContentClient()->browser()->CreateQuotaPermissionContext()));
   channel_->AddFilter(new content::GamepadBrowserMessageFilter(this));
   channel_->AddFilter(new ProfilerMessageFilter());
 }
 
 int RenderProcessHostImpl::GetNextRoutingID() {
   return widget_helper_->GetNextRoutingID();
 }
 
 void RenderProcessHostImpl::UpdateAndSendMaxPageID(int32 page_id) {
@@ skipping 770 matching lines @@
 void RenderProcessHostImpl::OnRevealFolderInOS(const FilePath& path) {
   // Only honor the request if appropriate persmissions are granted.
   if (ChildProcessSecurityPolicy::GetInstance()->CanReadFile(GetID(), path))
     content::GetContentClient()->browser()->OpenItem(path);
 }
 
 void RenderProcessHostImpl::OnSavedPageAsMHTML(int job_id, int64 data_size) {
   content::GetContentClient()->browser()->GetMHTMLGenerationManager()->
       MHTMLGenerated(job_id, data_size);
 }