Issue 8816021: Rescan cells at the end of mark-sweep. This means they don't need a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8816021: Rescan cells at the end of mark-sweep. This means they don't need a (Closed)

Created:
9 years ago by Erik Corry

Modified:
9 years ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Rescan cells at the end of mark-sweep. This means they don't need a write barrier. Committed: http://code.google.com/p/v8/source/detail?r=10187

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -38 lines)			Patch
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+5 lines, -9 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+1 line, -14 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+1 line, -15 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+16 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years ago (2011-12-06 15:28:15 UTC) #2

lgtm

http://codereview.chromium.org/8816021/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/8816021/diff/1/src/mark-compact.cc#newcode2085
src/mark-compact.cc:2085: // of the incremental sweeping.
at the end of incremental marking

http://codereview.chromium.org/8816021/diff/1/src/mark-compact.cc#newcode2086
src/mark-compact.cc:2086: {
Please check that we actually _had_ incremental marking, otherwise we just waste
time.

Expand Messages | Collapse Messages