Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 8816021: Rescan cells at the end of mark-sweep. This means they don't need a (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2126 matching lines...) Expand 10 before | Expand all | Expand 10 after
2137 // been deleted from the property dictionary. In that case, we need 2137 // been deleted from the property dictionary. In that case, we need
2138 // to update the property details in the property dictionary to mark 2138 // to update the property details in the property dictionary to mark
2139 // it as no longer deleted. We deoptimize in that case. 2139 // it as no longer deleted. We deoptimize in that case.
2140 if (instr->hydrogen()->RequiresHoleCheck()) { 2140 if (instr->hydrogen()->RequiresHoleCheck()) {
2141 __ cmp(FieldOperand(object, offset), factory()->the_hole_value()); 2141 __ cmp(FieldOperand(object, offset), factory()->the_hole_value());
2142 DeoptimizeIf(equal, instr->environment()); 2142 DeoptimizeIf(equal, instr->environment());
2143 } 2143 }
2144 2144
2145 // Store the value. 2145 // Store the value.
2146 __ mov(FieldOperand(object, offset), value); 2146 __ mov(FieldOperand(object, offset), value);
2147 2147 // Cells are always rescanned, so no write barrier here.
2148 // Cells are always in the remembered set.
2149 if (instr->hydrogen()->NeedsWriteBarrier()) {
2150 HType type = instr->hydrogen()->value()->type();
2151 SmiCheck check_needed =
2152 type.IsHeapObject() ? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
2153 __ RecordWriteField(object,
2154 offset,
2155 value,
2156 address,
2157 kSaveFPRegs,
2158 OMIT_REMEMBERED_SET,
2159 check_needed);
2160 }
2161 } 2148 }
2162 2149
2163 2150
2164 void LCodeGen::DoStoreGlobalGeneric(LStoreGlobalGeneric* instr) { 2151 void LCodeGen::DoStoreGlobalGeneric(LStoreGlobalGeneric* instr) {
2165 ASSERT(ToRegister(instr->context()).is(esi)); 2152 ASSERT(ToRegister(instr->context()).is(esi));
2166 ASSERT(ToRegister(instr->global_object()).is(edx)); 2153 ASSERT(ToRegister(instr->global_object()).is(edx));
2167 ASSERT(ToRegister(instr->value()).is(eax)); 2154 ASSERT(ToRegister(instr->value()).is(eax));
2168 2155
2169 __ mov(ecx, instr->name()); 2156 __ mov(ecx, instr->name());
2170 Handle<Code> ic = (instr->strict_mode_flag() == kStrictMode) 2157 Handle<Code> ic = (instr->strict_mode_flag() == kStrictMode)
(...skipping 2447 matching lines...) Expand 10 before | Expand all | Expand 10 after
4618 this, pointers, Safepoint::kLazyDeopt); 4605 this, pointers, Safepoint::kLazyDeopt);
4619 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator); 4606 __ InvokeBuiltin(Builtins::IN, CALL_FUNCTION, safepoint_generator);
4620 } 4607 }
4621 4608
4622 4609
4623 #undef __ 4610 #undef __
4624 4611
4625 } } // namespace v8::internal 4612 } } // namespace v8::internal
4626 4613
4627 #endif // V8_TARGET_ARCH_IA32 4614 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | src/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698