Issue 8816009: Don't track Smi->Double->Object element transitions for small undefined arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8816009: Don't track Smi->Double->Object element transitions for small undefined arrays. (Closed)

Created:
9 years ago by danno

Modified:
9 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't track Smi->Double->Object element transitions for small undefined arrays. R=jkummerow@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10181

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review feedback #

Patch Set 3 : Review feedback #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/parser.cc	View	1 2	3 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years ago (2011-12-06 10:01:12 UTC) #2

LGTM with a nit.

http://codereview.chromium.org/8816009/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/8816009/diff/1/src/parser.cc#newcode3382
src/parser.cc:3382: bool has_ony_undefined_values = true;
s/ony/only/

http://codereview.chromium.org/8816009/diff/1/src/parser.cc#newcode3406
src/parser.cc:3406: has_ony_undefined_values = false;
s/ony/only/

http://codereview.chromium.org/8816009/diff/1/src/parser.cc#newcode3448
src/parser.cc:3448: if (has_ony_undefined_values && values->length() <= 2) {
s/ony/only/

Expand Messages | Collapse Messages