Don't track Smi->Double->Object element transitions for small undefined arrays.

src/parser.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3359 matching lines @@
   }
   Expect(Token::RBRACK, CHECK_OK);
 
   // Update the scope information before the pre-parsing bailout.
   int literal_index = current_function_state_->NextMaterializedLiteralIndex();
 
   // Allocate a fixed array to hold all the object literals.
   Handle<FixedArray> object_literals =
       isolate()->factory()->NewFixedArray(values->length(), TENURED);
   Handle<FixedDoubleArray> double_literals;
+
   ElementsKind elements_kind = FAST_SMI_ONLY_ELEMENTS;
+  bool has_ony_undefined_values = true;

[Jakob Kummerow, 2011/12/06 10:01:12]

s/ony/only/

 
   // Fill in the literals.
   bool is_simple = true;
   int depth = 1;
   for (int i = 0, n = values->length(); i < n; i++) {
     MaterializedLiteral* m_literal = values->at(i)->AsMaterializedLiteral();
     if (m_literal != NULL && m_literal->depth() + 1 > depth) {
       depth = m_literal->depth() + 1;
     }
     Handle<Object> boilerplate_value = GetBoilerplateValue(values->at(i));
     if (boilerplate_value->IsUndefined()) {
       object_literals->set_the_hole(i);
       if (elements_kind == FAST_DOUBLE_ELEMENTS) {
         double_literals->set_the_hole(i);
       }
       is_simple = false;
     } else {
       // Examine each literal element, and adjust the ElementsKind if the
       // literal element is not of a type that can be stored in the current
       // ElementsKind.  Start with FAST_SMI_ONLY_ELEMENTS, and transition to
       // FAST_DOUBLE_ELEMENTS and FAST_ELEMENTS as necessary.  Always remember
       // the tagged value, no matter what the ElementsKind is in case we
       // ultimately end up in FAST_ELEMENTS.
+      has_ony_undefined_values = false;

[Jakob Kummerow, 2011/12/06 10:01:12]

s/ony/only/

       object_literals->set(i, *boilerplate_value);
       if (elements_kind == FAST_SMI_ONLY_ELEMENTS) {
         // Smi only elements. Notice if a transition to FAST_DOUBLE_ELEMENTS or
         // FAST_ELEMENTS is required.
         if (!boilerplate_value->IsSmi()) {
           if (boilerplate_value->IsNumber() && FLAG_smi_only_arrays) {
             // Allocate a double array on the FAST_DOUBLE_ELEMENTS transition to
             // avoid over-allocating in TENURED space.
             double_literals = isolate()->factory()->NewFixedDoubleArray(
                 values->length(), TENURED);
@@ skipping 18 matching lines @@
         // until the first value is seen that can't be stored as a double.
         if (boilerplate_value->IsNumber()) {
           double_literals->set(i, boilerplate_value->Number());
         } else {
           elements_kind = FAST_ELEMENTS;
         }
       }
     }
   }
 
+  // Very small array literals that don't have a concrete hint about their type
+  // from a constant value should default to the slow case to avoid lots of
+  // elements transitions on really small objects.
+  if (has_ony_undefined_values && values->length() <= 2) {

[Jakob Kummerow, 2011/12/06 10:01:12]

s/ony/only/

+    elements_kind = FAST_ELEMENTS;
+  }
+
   // Simple and shallow arrays can be lazily copied, we transform the
   // elements array to a copy-on-write array.
   if (is_simple && depth == 1 && values->length() > 0 &&
       elements_kind != FAST_DOUBLE_ELEMENTS) {
     object_literals->set_map(isolate()->heap()->fixed_cow_array_map());
   }
 
   Handle<FixedArrayBase> element_values = elements_kind == FAST_DOUBLE_ELEMENTS
       ? Handle<FixedArrayBase>(double_literals)
       : Handle<FixedArrayBase>(object_literals);
@@ skipping 2214 matching lines @@
       ASSERT(info->isolate()->has_pending_exception());
     } else {
       result = parser.ParseProgram(info);
     }
   }
   info->SetFunction(result);
   return (result != NULL);
 }
 
 } }  // namespace v8::internal