Remove aura::RootWindow instance from LayerAnimator::observers_ when the window is deleted

Remove aura::RootWindow instance from LayerAnimator::observers_ and LayerAnimationSequence::observers_ when the window is deleted.

This would prevent Chrome from crashing (see the example stack trace below) when someone (e.g. ui/aura_shell/shell_accelerator_controller.cc) adds aura::RootWindow as an observer of a LayerAnimationSequence object, and the window is deleted before the animation finishes.

pure virtual method called
terminate called without an active exception
[24029:24029:1206/172212:111412790729:ERROR:process_util_posix.cc(139)] Received signal 6
        base::debug::StackTrace::StackTrace() [0x809fbf4]
        base::(anonymous namespace)::StackDumpSignalHandler() [0x830b615]
...
        ui::LayerAnimationSequence::NotifyAborted() [0x826fcce]
        ui::LayerAnimationSequence::Abort() [0x826f95b]
        ui::LayerAnimator::ClearAnimations() [0x8274f84]
        ui::LayerAnimator::~LayerAnimator() [0x8273a74]
        scoped_ptr<>::~scoped_ptr() [0x826c7e3]
        ui::Layer::~Layer() [0x8269873]
        scoped_ptr<>::~scoped_ptr() [0x81b7891]
        aura::Window::~Window() [0x81b4745]
        aura::RootWindow::~RootWindow() [0x81ae824]
        aura::RootWindow::DeleteInstance() [0x81ace70]

With the aura::RootWindow fix, we can reenable one test in shell_accelerator_controller_unittests.cc which checks the Control+Home accelerator.

BUG=None
TEST=ran aura_shell_unittests



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113762

[Ben Goodger (Google), 2011-12-08 17:14:16]

LGTM provided RemoveObserver is safe against removing an observer that was never
registered.

http://codereview.chromium.org/8816008/diff/4001/ui/aura/root_window.cc
File ui/aura/root_window.cc (right):

http://codereview.chromium.org/8816008/diff/4001/ui/aura/root_window.cc#newco...
ui/aura/root_window.cc:437: layer()->GetAnimator()->RemoveObserver(this);
You should add a comment here that an observer may have been added by an
animation on the RootWindow

[Yusuke Sato, 2011-12-09 01:50:59]

http://codereview.chromium.org/8816008/diff/4001/ui/aura/root_window.cc
File ui/aura/root_window.cc (right):

http://codereview.chromium.org/8816008/diff/4001/ui/aura/root_window.cc#newco...
ui/aura/root_window.cc:437: layer()->GetAnimator()->RemoveObserver(this);
On 2011/12/08 17:14:17, Ben Goodger (Google) wrote:
> You should add a comment here that an observer may have been added by an
> animation on the RootWindow

Done.

[commit-bot: I haz the power, 2011-12-09 01:57:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/8816008/8001

[commit-bot: I haz the power, 2011-12-09 02:49:42]

Try job failure for 8816008-8001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-12-09 03:44:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/8816008/8001

[commit-bot: I haz the power, 2011-12-09 04:56:20]

Change committed as 113762