Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: ui/aura_shell/shell_accelerator_controller_unittest.cc

Issue 8816008: Remove aura::RootWindow instance from LayerAnimator::observers_ when the window is deleted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/root_window.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura_shell/shell_accelerator_controller_unittest.cc
diff --git a/ui/aura_shell/shell_accelerator_controller_unittest.cc b/ui/aura_shell/shell_accelerator_controller_unittest.cc
index 39e1c6486045eaf07d07bb42a8dc6f985242abfb..d0d4d73a6db99289137094274012763b614de8c0 100644
--- a/ui/aura_shell/shell_accelerator_controller_unittest.cc
+++ b/ui/aura_shell/shell_accelerator_controller_unittest.cc
@@ -154,11 +154,9 @@ TEST_F(ShellAcceleratorControllerTest, GlobalAccelerators) {
// EXPECT_TRUE(GetController()->Process(
// ui::Accelerator(ui::VKEY_PRINT, false, false, false)));
#if !defined(NDEBUG)
- // TODO(mazda): Callig RotateScreen in unit test causes a crash because of
- // "pure virtual method called" for some reasons. Need to investigate.
// RotateScreen
- // EXPECT_TRUE(GetController()->Process(
- // ui::Accelerator(ui::VKEY_HOME, false, true, false)));
+ EXPECT_TRUE(GetController()->Process(
+ ui::Accelerator(ui::VKEY_HOME, false, true, false)));
#if !defined(OS_LINUX)
// ToggleDesktopFullScreen (not implemented yet on Linux)
EXPECT_TRUE(GetController()->Process(
« no previous file with comments | « ui/aura/root_window.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698