Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 8815005: Lands http://codereview.chromium.org/8801034/ in hopes of getting a (Closed)

Created:
9 years ago by sky
Modified:
9 years ago
Reviewers:
sail, jwd
CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Lands http://codereview.chromium.org/8801034/ in hopes of getting a green tree. TBRing since this is a revert. R=sail@chromium.org, jwd@chromium.org BUG=87658 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -195 lines) Patch
M chrome/browser/profiles/profile_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 4 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 3 chunks +10 lines, -56 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 10 chunks +27 lines, -64 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 4 chunks +4 lines, -16 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years ago (2011-12-06 05:30:12 UTC) #1
sail
9 years ago (2011-12-06 05:33:27 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698