Lands http://codereview.chromium.org/8801034/ in hopes of getting a

chrome/browser/profiles/profile_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
@@ skipping 79 matching lines @@
     base::SystemMonitor::AllocateSystemIOPorts();
 #endif
     system_monitor_dummy_.reset(new base::SystemMonitor);
     static_cast<TestingBrowserProcess*>(g_browser_process)->SetIOThread(
         &io_thread_);
   }
 
   virtual void SetUp() {
     // Create a new temporary directory, and store the path
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
-    static_cast<TestingBrowserProcess*>(g_browser_process)->SetProfileManager(
-        new testing::ProfileManager(temp_dir_.path()));
+    profile_manager_.reset(new testing::ProfileManager(temp_dir_.path()));
 #if defined(OS_WIN)
     // Force the ProfileInfoCache to be created immediately, so we can
     // remove the shortcut manager for testing.
-    ProfileManager* profile_manager = g_browser_process->profile_manager();
-    profile_manager->GetProfileInfoCache();
-    profile_manager->RemoveProfileShortcutManagerForTesting();
+    profile_manager_->GetProfileInfoCache();
+    profile_manager_->RemoveProfileShortcutManagerForTesting();
 #endif
 #if defined(OS_CHROMEOS)
   CommandLine *cl = CommandLine::ForCurrentProcess();
   cl->AppendSwitch(switches::kTestType);
 #endif
   }
 
   virtual void TearDown() {
-    static_cast<TestingBrowserProcess*>(g_browser_process)->SetProfileManager(
-        NULL);
+    profile_manager_.reset();
     message_loop_.RunAllPending();
   }
 
   class MockObserver : public ProfileManagerObserver {
    public:
     MOCK_METHOD2(OnProfileCreated, void(Profile* profile, Status status));
   };
 
 #if defined(OS_CHROMEOS)
   // Do not change order of stub_cros_enabler_, which needs to be constructed
   // before io_thread_ which requires CrosLibrary to be initialized to construct
   // its data member pref_proxy_config_tracker_ on ChromeOS.
   chromeos::ScopedStubCrosEnabler stub_cros_enabler_;
 #endif
 
   // The path to temporary directory used to contain the test operations.
   ScopedTempDir temp_dir_;
   ScopedTestingLocalState local_state_;
   scoped_refptr<ExtensionEventRouterForwarder>
       extension_event_router_forwarder_;
 
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread db_thread_;
   content::TestBrowserThread file_thread_;
   // IOThread is necessary for the creation of some services below.
   IOThread io_thread_;
 
   scoped_ptr<base::SystemMonitor> system_monitor_dummy_;
+
+  // Also will test profile deletion.
+  scoped_ptr<ProfileManager> profile_manager_;
 };
 
 TEST_F(ProfileManagerTest, GetProfile) {
   FilePath dest_path = temp_dir_.path();
   dest_path = dest_path.Append(FILE_PATH_LITERAL("New Profile"));
 
-  ProfileManager* profile_manager = g_browser_process->profile_manager();
-
   Profile* profile;
 
   // Successfully create a profile.
-  profile = profile_manager->GetProfile(dest_path);
+  profile = profile_manager_->GetProfile(dest_path);
   EXPECT_TRUE(profile);
 
   // The profile already exists when we call GetProfile. Just load it.
-  EXPECT_EQ(profile, profile_manager->GetProfile(dest_path));
+  EXPECT_EQ(profile, profile_manager_->GetProfile(dest_path));
 }
 
 TEST_F(ProfileManagerTest, DefaultProfileDir) {
   FilePath expected_default =
       FilePath().AppendASCII(chrome::kInitialProfile);
-  EXPECT_EQ(
-      expected_default.value(),
-      g_browser_process->profile_manager()->GetInitialProfileDir().value());
+  EXPECT_EQ(expected_default.value(),
+            profile_manager_->GetInitialProfileDir().value());
 }
 
 #if defined(OS_CHROMEOS)
 // This functionality only exists on Chrome OS.
 TEST_F(ProfileManagerTest, LoggedInProfileDir) {
   CommandLine *cl = CommandLine::ForCurrentProcess();
   std::string profile_dir("my_user");
 
   cl->AppendSwitchASCII(switches::kLoginProfile, profile_dir);
 
   FilePath expected_default =
       FilePath().AppendASCII(chrome::kInitialProfile);
-  ProfileManager* profile_manager = g_browser_process->profile_manager();
   EXPECT_EQ(expected_default.value(),
-            profile_manager->GetInitialProfileDir().value());
+            profile_manager_->GetInitialProfileDir().value());
 
-  profile_manager->Observe(chrome::NOTIFICATION_LOGIN_USER_CHANGED,
+  profile_manager_->Observe(chrome::NOTIFICATION_LOGIN_USER_CHANGED,
                            content::NotificationService::AllSources(),
                            content::NotificationService::NoDetails());
   FilePath expected_logged_in(profile_dir);
   EXPECT_EQ(expected_logged_in.value(),
-            profile_manager->GetInitialProfileDir().value());
+            profile_manager_->GetInitialProfileDir().value());
   VLOG(1) << temp_dir_.path().Append(
-      profile_manager->GetInitialProfileDir()).value();
+      profile_manager_->GetInitialProfileDir()).value();
 }
 
 #endif
 
 TEST_F(ProfileManagerTest, CreateAndUseTwoProfiles) {
   FilePath dest_path1 = temp_dir_.path();
   dest_path1 = dest_path1.Append(FILE_PATH_LITERAL("New Profile 1"));
 
   FilePath dest_path2 = temp_dir_.path();
   dest_path2 = dest_path2.Append(FILE_PATH_LITERAL("New Profile 2"));
 
-  ProfileManager* profile_manager = g_browser_process->profile_manager();
-
   // Successfully create the profiles.
   TestingProfile* profile1 =
-      static_cast<TestingProfile*>(profile_manager->GetProfile(dest_path1));
+      static_cast<TestingProfile*>(profile_manager_->GetProfile(dest_path1));
   ASSERT_TRUE(profile1);
 
   TestingProfile* profile2 =
-      static_cast<TestingProfile*>(profile_manager->GetProfile(dest_path2));
+      static_cast<TestingProfile*>(profile_manager_->GetProfile(dest_path2));
   ASSERT_TRUE(profile2);
 
   // Force lazy-init of some profile services to simulate use.
   profile1->CreateHistoryService(true, false);
   EXPECT_TRUE(profile1->GetHistoryService(Profile::EXPLICIT_ACCESS));
   profile1->CreateBookmarkModel(true);
   EXPECT_TRUE(profile1->GetBookmarkModel());
   profile2->CreateBookmarkModel(true);
   EXPECT_TRUE(profile2->GetBookmarkModel());
   profile2->CreateHistoryService(true, false);
   EXPECT_TRUE(profile2->GetHistoryService(Profile::EXPLICIT_ACCESS));
 
   // Make sure any pending tasks run before we destroy the profiles.
   message_loop_.RunAllPending();
 
-  static_cast<TestingBrowserProcess*>(g_browser_process)->SetProfileManager(
-      NULL);
+  profile_manager_.reset();
 
   // Make sure history cleans up correctly.
   message_loop_.RunAllPending();
 }
 
 MATCHER(NotFail, "Profile creation failure status is not reported.") {
   return arg == ProfileManagerObserver::STATUS_CREATED ||
       arg == ProfileManagerObserver::STATUS_INITIALIZED;
 }
 
 // Tests asynchronous profile creation mechanism.
 TEST_F(ProfileManagerTest, DISABLED_CreateProfileAsync) {
   FilePath dest_path =
       temp_dir_.path().Append(FILE_PATH_LITERAL("New Profile"));
 
   MockObserver mock_observer;
   EXPECT_CALL(mock_observer, OnProfileCreated(
       testing::NotNull(), NotFail())).Times(testing::AtLeast(1));
 
-  g_browser_process->profile_manager()->CreateProfileAsync(dest_path,
-                                                           &mock_observer);
+  profile_manager_->CreateProfileAsync(dest_path, &mock_observer);
 
   message_loop_.RunAllPending();
 }
 
 MATCHER(SameNotNull, "The same non-NULL value for all calls.") {
   if (!g_created_profile)
     g_created_profile = arg;
   return arg != NULL && arg == g_created_profile;
 }
 
 TEST_F(ProfileManagerTest, CreateProfileAsyncMultipleRequests) {
   FilePath dest_path =
       temp_dir_.path().Append(FILE_PATH_LITERAL("New Profile"));
 
   g_created_profile = NULL;
 
   MockObserver mock_observer1;
   EXPECT_CALL(mock_observer1, OnProfileCreated(
       SameNotNull(), NotFail())).Times(testing::AtLeast(1));
   MockObserver mock_observer2;
   EXPECT_CALL(mock_observer2, OnProfileCreated(
       SameNotNull(), NotFail())).Times(testing::AtLeast(1));
   MockObserver mock_observer3;
   EXPECT_CALL(mock_observer3, OnProfileCreated(
       SameNotNull(), NotFail())).Times(testing::AtLeast(1));
 
-  ProfileManager* profile_manager = g_browser_process->profile_manager();
-
-  profile_manager->CreateProfileAsync(dest_path, &mock_observer1);
-  profile_manager->CreateProfileAsync(dest_path, &mock_observer2);
-  profile_manager->CreateProfileAsync(dest_path, &mock_observer3);
+  profile_manager_->CreateProfileAsync(dest_path, &mock_observer1);
+  profile_manager_->CreateProfileAsync(dest_path, &mock_observer2);
+  profile_manager_->CreateProfileAsync(dest_path, &mock_observer3);
 
   message_loop_.RunAllPending();
 }
 
 TEST_F(ProfileManagerTest, CreateProfilesAsync) {
   FilePath dest_path1 =
       temp_dir_.path().Append(FILE_PATH_LITERAL("New Profile 1"));
   FilePath dest_path2 =
       temp_dir_.path().Append(FILE_PATH_LITERAL("New Profile 2"));
 
   MockObserver mock_observer;
   EXPECT_CALL(mock_observer, OnProfileCreated(
       testing::NotNull(), NotFail())).Times(testing::AtLeast(3));
 
-  ProfileManager* profile_manager = g_browser_process->profile_manager();
-
-  profile_manager->CreateProfileAsync(dest_path1, &mock_observer);
-  profile_manager->CreateProfileAsync(dest_path2, &mock_observer);
+  profile_manager_->CreateProfileAsync(dest_path1, &mock_observer);
+  profile_manager_->CreateProfileAsync(dest_path2, &mock_observer);
 
   message_loop_.RunAllPending();
 }
 
 TEST_F(ProfileManagerTest, AutoloadProfilesWithBackgroundApps) {
-  ProfileManager* profile_manager = g_browser_process->profile_manager();
-  ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
+  ProfileInfoCache& cache = profile_manager_->GetProfileInfoCache();
 
   EXPECT_EQ(0u, cache.GetNumberOfProfiles());
   cache.AddProfileToCache(cache.GetUserDataDir().AppendASCII("path_1"),
                           ASCIIToUTF16("name_1"), string16(), 0);
   cache.AddProfileToCache(cache.GetUserDataDir().AppendASCII("path_2"),
                           ASCIIToUTF16("name_2"), string16(), 0);
   cache.AddProfileToCache(cache.GetUserDataDir().AppendASCII("path_3"),
                           ASCIIToUTF16("name_3"), string16(), 0);
   cache.SetBackgroundStatusOfProfileAtIndex(0, true);
   cache.SetBackgroundStatusOfProfileAtIndex(2, true);
   EXPECT_EQ(3u, cache.GetNumberOfProfiles());
 
-  profile_manager->AutoloadProfiles();
+  profile_manager_->AutoloadProfiles();
 
-  EXPECT_EQ(2u, profile_manager->GetLoadedProfiles().size());
+  EXPECT_EQ(2u, profile_manager_->GetLoadedProfiles().size());
 }
-
-TEST_F(ProfileManagerTest, InitProfileUserPrefs) {
-  FilePath dest_path = temp_dir_.path();
-  dest_path = dest_path.Append(FILE_PATH_LITERAL("New Profile"));
-
-  ProfileManager* profile_manager = g_browser_process->profile_manager();
-
-  Profile* profile;
-
-  // Successfully create the profile
-  profile = profile_manager->GetProfile(dest_path);
-  ASSERT_TRUE(profile);
-
-  // Check that the profile name is non empty
-  std::string profile_name =
-      profile->GetPrefs()->GetString(prefs::kProfileName);
-  EXPECT_FALSE(profile_name.empty());
-
-  // Check that the profile avatar index is valid
-  size_t avatar_index = profile->GetPrefs()->GetInteger(
-      prefs::kProfileAvatarIndex);
-  EXPECT_TRUE(profile_manager->GetProfileInfoCache().IsDefaultAvatarIconIndex(
-      avatar_index));
-}