Issue 8815004: Aura: delay draw on Expose to avoid getting behind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8815004: Aura: delay draw on Expose to avoid getting behind (Closed)

Created:
9 years ago by piman

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Aura: delay draw on Expose to avoid getting behind Previously, each Expose event (caused e.g. when you move the host window) would trigger an immediate redraw, which can take a long time (vsyng, GPU load, ...). Instead, schedule a redraw so that multiple expose can get gathered into a single redraw. BUG=None TEST=launch chrome/aura, move the window around for a few seconds, check that things are interactive again right away. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113154

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	ui/aura/desktop.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
	M	ui/aura/desktop_host_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm http://codereview.chromium.org/8815004/diff/1/ui/aura/desktop.h File ui/aura/desktop.h (right): http://codereview.chromium.org/8815004/diff/1/ui/aura/desktop.h#newcode153 ui/aura/desktop.h:153: // Overridden from ui::CompositorDelegate nit: colon at the ...

9 years ago (2011-12-06 04:26:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8815004/4

9 years ago (2011-12-06 04:36:46 UTC) #3

Change committed as 113154

Expand Messages | Collapse Messages