Issue 8811001: Oust BubbleWindow from ExtensionDialog, use chromeos::BubbleFrameView directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8811001: Oust BubbleWindow from ExtensionDialog, use chromeos::BubbleFrameView directly. (Closed)

Created:
9 years ago by msw

Modified:
9 years ago

Reviewers:
James Cook, Emmanuel Saint-loubert-Bié

CC:
chromium-reviews, jstritar+watch_chromium.org, nkostylev+watch_chromium.org, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, bshe

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Oust BubbleWindow from ExtensionDialog, use chromeos::BubbleFrameView directly. Override CreateNonClientFrameView to return a chromeos::BubbleFrameView directly. This circumvents the NativeWidgetGtk hackery of BubbleWindow. Save and open SelectFileExtensionDialog instances look good. Bookmark All Tabs dialog looks good on non-aura, blocked on aura by crbug.com/106474. BUG=106230 TEST=ExtensionDialogs look the same on CrOS, and now similar on Aura. CLOSING THIS ISSUE (SUPERSEDED BY codereview.chromium.org/8800032)

Patch Set 1 : Oust BubbleWindow use from ExtensionDialog, use chromeos::BubbleFrameView directly. #

Patch Set 2 : Build requisite and non-breaking chrome/browser/chromeos/frame/ files in aura cros. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -29 lines)			Patch
M	chrome/browser/chromeos/frame/bubble_frame_view.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/frame/bubble_frame_view.cc	View		4 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/frame/bubble_window_gtk.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_dialog.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_dialog.cc	View		2 chunks	+14 lines, -8 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

msw

PTAL; thanks! (pix temporarily available at \\filer\home\msw\Chrome\bubbles)

9 years ago (2011-12-05 23:27:25 UTC) #1

James Cook

9 years ago (2011-12-06 04:49:17 UTC) #3

Superseded by codereview.chromium.org/8800032 and that issue LGTM.

Expand Messages | Collapse Messages