chrome/browser/chromeos/frame/bubble_window_gtk.cc - Issue 8811001: Oust BubbleWindow from ExtensionDialog, use chromeos::BubbleFrameView directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/frame/bubble_window_gtk.cc

Issue 8811001: Oust BubbleWindow from ExtensionDialog, use chromeos::BubbleFrameView directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Build requisite and non-breaking chrome/browser/chromeos/frame/ files in aura cros. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/frame/bubble_window_gtk.cc

diff --git a/chrome/browser/chromeos/frame/bubble_window_gtk.cc b/chrome/browser/chromeos/frame/bubble_window_gtk.cc

index 67846e64a6c5402119741553ea4c8a3535c15684..e2cc928cc18aa53d2337ed58f392ea8ee91f879b 100644

--- a/chrome/browser/chromeos/frame/bubble_window_gtk.cc

+++ b/chrome/browser/chromeos/frame/bubble_window_gtk.cc

@@ -41,8 +41,7 @@ void BubbleWindow::InitNativeWidget(const views::Widget::InitParams& params) {

}

views::NonClientFrameView* BubbleWindow::CreateNonClientFrameView() {

- views::Widget* window = GetWidget();

- return new BubbleFrameView(window, window->widget_delegate(), style_);

+ return new BubbleFrameView(GetWidget()->widget_delegate(), style_);

}

views::Widget* BubbleWindow::Create(

« no previous file with comments | « chrome/browser/chromeos/frame/bubble_frame_view.cc ('k') | chrome/browser/ui/views/extensions/extension_dialog.h » ('j') | no next file with comments »