More OS X Breakpad integration

Last chunk of OS X Breakpad integration:
* Link agasint Breakpad from public svn repo.
* Bump DEPS to new svn rev of Breakpad with fixes for 10.5 compilation.
* Fill in code to differentiate between processes types in crash report.

[John Grabowski, 2009-04-21 20:48:41]

LGTM

Be sure to ping jonc in case there is something he should do (or should ask
krisr to do) to smoke this in a release build before pushing the next one out.

http://codereview.chromium.org/88043/diff/1/4
File chrome/app/breakpad_mac.mm (right):

http://codereview.chromium.org/88043/diff/1/4#newcode90
Line 90: NSString* version_str = [info_dictionary
objectForKey:@BREAKPAD_VERSION];
Add a comment as to origin: "these variables are added to our plist when
building a branded Chrome.app"

http://codereview.chromium.org/88043/diff/1/6
File chrome/chrome.gyp (right):

http://codereview.chromium.org/88043/diff/1/6#newcode1651
Line 1651: '../breakpad/breakpad.gyp:breakpad',
So glad you could clean this up.

[jon, 2009-04-21 21:29:45]

I am worried about http://crbug.com/9866 which caused us to revert breakpad last
time.  We should not check this in until we either understand that problem and
have fixed it or (at least) I have cut the new dev channel release so we do not
hold up that release.

On 2009/04/21 20:48:41, John Grabowski wrote:
> LGTM
> 
> Be sure to ping jonc in case there is something he should do (or should ask
> krisr to do) to smoke this in a release build before pushing the next one out.
> 
> http://codereview.chromium.org/88043/diff/1/4
> File chrome/app/breakpad_mac.mm (right):
> 
> http://codereview.chromium.org/88043/diff/1/4#newcode90
> Line 90: NSString* version_str = [info_dictionary
> objectForKey:@BREAKPAD_VERSION];
> Add a comment as to origin: "these variables are added to our plist when
> building a branded Chrome.app"
> 
> http://codereview.chromium.org/88043/diff/1/6
> File chrome/chrome.gyp (right):
> 
> http://codereview.chromium.org/88043/diff/1/6#newcode1651
> Line 1651: '../breakpad/breakpad.gyp:breakpad',
> So glad you could clean this up.

[John Grabowski, 2009-04-22 00:01:57]

Still LGTM

http://codereview.chromium.org/88043/diff/2008/2011
File chrome/app/breakpad_mac.mm (right):

http://codereview.chromium.org/88043/diff/2008/2011#newcode63
Line 63: void InitCrashReporter() {
Add a comment that InitCrashReporter() is only called for a branded build

http://codereview.chromium.org/88043/diff/2008/2011#newcode107
Line 107: NSString* version_str = [info_dictionary
objectForKey:@BREAKPAD_VERSION];
Feedback not applied or responded on this line