Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: chrome/chrome.gyp

Issue 88043: More OS X Breakpad integration (Closed)
Patch Set: Fix jrg's comments. Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/breakpad_mac.mm ('K') | « chrome/app/chrome_dll_main.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index fe47cc4498a2ff814918cd04e4008aaa07c67122..2934fc2406c63588bbf2f4f1b4cef8524c45c7c3 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -213,10 +213,6 @@
'common/libxml_utils.h',
'common/logging_chrome.cc',
'common/logging_chrome.h',
- 'common/mach_ipc_mac.h',
- 'common/mach_ipc_mac.mm',
- 'common/mach_message_source_mac.cc',
- 'common/mach_message_source_mac.h',
'common/main_function_params.h',
'common/message_box_flags.h',
'common/message_router.cc',
@@ -1650,6 +1646,16 @@
# "bundle_id" is the name of the variable used to replace
# BUNDLE_ID in Info.plist.
'variables': {'bundle_id': 'com.google.Chrome'},
+ # Only include breakpad in official builds.
+ 'dependencies': [
+ '../breakpad/breakpad.gyp:breakpad',
+ ],
+# 'copies': [
+# {
+# 'destination': '<(PRODUCT_DIR)/<(branding).app/Contents/Resources/',
+# 'files': ['<(PRODUCT_DIR)/crash_inspector', '<(PRODUCT_DIR)/crash_report_sender.app'],
+# },
+# ]
}, { # else: branding!="Chrome"
'mac_bundle_resources': ['app/theme/chromium/app.icns'],
'variables': {'bundle_id': 'org.chromium.Chromium'},
@@ -2116,7 +2122,7 @@
'..',
],
'sources': [
- 'app/breakpad_mac.mm',
+ 'app/breakpad_mac_stubs.mm',
# All unittests in browser, common, and renderer.
'browser/autocomplete/autocomplete_unittest.cc',
'browser/autocomplete/history_contents_provider_unittest.cc',
« chrome/app/breakpad_mac.mm ('K') | « chrome/app/chrome_dll_main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698