Reland 8688002: PPB_TCPSocket_Private/PPB_UDPSocket_Private are exposed to Browser

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index a89b4731b834c0a54168d5272006a0a680335c7a..01618484fcfa87dcf9b4ebfdf6f33568cc03b8f2 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -436,10 +436,13 @@ RenderViewImpl::RenderViewImpl(
         RenderThreadImpl::current()->video_capture_impl_manager());
   }
 
+  AddObserver(&pepper_delegate_);

[jam, 2011/12/05 19:26:36]

nit: here and below, in general we try to avoid RenderViewImpl doing this for
observers, hence why I prefer to have it done automatically for
PepperPluginDelegate in its RenderViewObserver constructor

[Dmitry Polukhin, 2011/12/05 19:53:51]

Changing members order is not very reliable because RenderViewImpl will not be
fully constructed when RenderViewObserver constructor is called so if later
AddObserver tries to use any other member it may not be constructed - need to be
careful in future. I think better way is to make pepper_delegate_ pointer and
init it in constructor when all members are ready for sure. But it will also
require to destroy it explicit in destructor to avoid the same problem in
destructor. But I don't have strong opinion and will do according to your
preference (pointer or change members order).

+
   content::GetContentClient()->renderer()->RenderViewCreated(this);
 }
 
 RenderViewImpl::~RenderViewImpl() {
+  RemoveObserver(&pepper_delegate_);
   history_page_ids_.clear();
 
   if (decrement_shared_popup_at_destruction_)