Reland 8688002: PPB_TCPSocket_Private/PPB_UDPSocket_Private are exposed to Browser

content/renderer/render_view_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 418 matching lines @@
   renderer_accessibility_ = new RendererAccessibility(this);
 
   new IdleUserDetector(this);
 
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kEnableMediaStream)) {
     media_stream_impl_ = new MediaStreamImpl(
         RenderThreadImpl::current()->video_capture_impl_manager());
   }
 
+  AddObserver(&pepper_delegate_);

[jam, 2011/12/05 19:26:36]

nit: here and below, in general we try to avoid RenderViewImpl doing this for
observers, hence why I prefer to have it done automatically for
PepperPluginDelegate in its RenderViewObserver constructor

[Dmitry Polukhin, 2011/12/05 19:53:51]

Changing members order is not very reliable because RenderViewImpl will not be
fully constructed when RenderViewObserver constructor is called so if later
AddObserver tries to use any other member it may not be constructed - need to be
careful in future. I think better way is to make pepper_delegate_ pointer and
init it in constructor when all members are ready for sure. But it will also
require to destroy it explicit in destructor to avoid the same problem in
destructor. But I don't have strong opinion and will do according to your
preference (pointer or change members order).

+
   content::GetContentClient()->renderer()->RenderViewCreated(this);
 }
 
 RenderViewImpl::~RenderViewImpl() {
+  RemoveObserver(&pepper_delegate_);
   history_page_ids_.clear();
 
   if (decrement_shared_popup_at_destruction_)
     shared_popup_counter_->data--;
 
   // If file chooser is still waiting for answer, dispatch empty answer.
   while (!file_chooser_completions_.empty()) {
     if (file_chooser_completions_.front()->completion) {
       file_chooser_completions_.front()->completion->didChooseFile(
           WebVector<WebString>());
@@ skipping 4336 matching lines @@
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit(
     const IPC::ChannelHandle& channel_handle) {
   DCHECK(!java_bridge_dispatcher_.get());
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_.reset(new JavaBridgeDispatcher(this, channel_handle));
 #endif
 }