Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 8802029: Remove 2 pointless NULL checks. (Closed)

Created:
9 years ago by Nico
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove 2 pointless NULL checks. These two functions are normal functions these days and can't be NULL. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/common/child_process_logging_mac.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
9 years ago (2011-12-06 00:47:13 UTC) #1
Scott Hess - ex-Googler
LGTM. I believe that all of the X()-calling XImpl() functions in there are there because ...
9 years ago (2011-12-06 00:49:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8802029/1
9 years ago (2011-12-06 00:50:22 UTC) #3
commit-bot: I haz the power
Try job failure for 8802029-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-06 01:34:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8802029/1
9 years ago (2011-12-06 01:40:10 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-06 07:30:00 UTC) #6
Change committed as 113145

Powered by Google App Engine
This is Rietveld 408576698