chrome/common/child_process_logging_mac.mm - Issue 8802029: Remove 2 pointless NULL checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/child_process_logging_mac.mm

Issue 8802029: Remove 2 pointless NULL checks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/child_process_logging_mac.mm

diff --git a/chrome/common/child_process_logging_mac.mm b/chrome/common/child_process_logging_mac.mm

index 21bc3698e45ca8a7e84b94ad71230b56f128045d..d539e465b07e18fb13f09e8827584dc7ca536316 100644

--- a/chrome/common/child_process_logging_mac.mm

+++ b/chrome/common/child_process_logging_mac.mm

@@ -176,10 +176,8 @@ void SetNumberOfViews(int number_of_views) {

}

void SetCommandLine(const CommandLine* command_line) {

- DCHECK(SetCrashKeyValue);

- DCHECK(ClearCrashKey);

DCHECK(command_line);

- if (!command_line || !SetCrashKeyValue || !ClearCrashKey)

+ if (!command_line)

return;

// These should match the corresponding strings in breakpad_win.cc.

« no previous file with comments | « no previous file | no next file » | no next file with comments »