Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 8802021: Fix a couple panel overflow related bugs. (Closed)

Created:
9 years ago by jianli
Modified:
9 years ago
Reviewers:
jennb
CC:
chromium-reviews, jennb, Dmitry Titov, jianli, prasadt, dcheng, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix a couple panel overflow related bugs. 1) Moving mouse to left screen edge causes the expanded overflow panels to shrink back. 2) Overflow panel is brought to normal area cannot be dragged correctly. BUG=106434 TEST=Enable overflow test plus manual test by moving mouse to left screen edge or clicking on overflow panel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113053

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/browser/ui/panels/base_panel_browser_test.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/panel_overflow_strip.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_strip.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jianli
9 years ago (2011-12-05 21:10:46 UTC) #1
jennb
LGTM if try bots are happy. http://codereview.chromium.org/8802021/diff/1/chrome/browser/ui/panels/panel_browsertest.cc File chrome/browser/ui/panels/panel_browsertest.cc (left): http://codereview.chromium.org/8802021/diff/1/chrome/browser/ui/panels/panel_browsertest.cc#oldcode124 chrome/browser/ui/panels/panel_browsertest.cc:124: EXPECT_EQ(Panel::IN_OVERFLOW, panel4->expansion_state()); Probably ...
9 years ago (2011-12-05 21:20:09 UTC) #2
jianli
9 years ago (2011-12-05 23:05:38 UTC) #3
All Jenn's feedbacks have been addressed.

I only ran panel related tests for WIN try bot.

WIN: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/6706

MAC: http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/6371

Powered by Google App Engine
This is Rietveld 408576698