Fix a couple panel overflow related bugs.

chrome/browser/ui/panels/panel_strip.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_strip.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 81 matching lines @@
   int height = restored_size.height();
   int width = restored_size.width();
 
   if (panel->initialized()) {
     // Bump panels in the strip to make room for this panel.
     int x;
     while ((x = GetRightMostAvailablePosition() - width) < display_area_.x()) {
       DCHECK(!panels_.empty());
       MovePanelToOverflow(panels_.back(), false);
     }
+    panel->SetExpansionState(Panel::EXPANDED);

[jennb, 2011/12/05 21:20:10]

Move this after line 104. Seems better than putting this in the middle of bounds
calculations as SetExpansionState also results in bounds calculations.

     int y = display_area_.bottom() - height;
     panel->SetPanelBounds(gfx::Rect(x, y, width, height));
   } else {
     // Initialize the newly created panel. Does not bump any panels from strip.
     if (height == 0 && width == 0) {
       // Auto resizable is enabled only if no initial size is provided.
       panel->SetAutoResizable(true);
     } else {
       if (height == 0)
         height = width / kPanelDefaultWidthToHeightRatio;
@@ skipping 30 matching lines @@
           base::Bind(&PanelStrip::MovePanelToOverflow,
                      base::Unretained(this),
                      panel,
                      true),  // new panel
           delay_ms);
     }
 #endif
     panel->Initialize(gfx::Rect(x, y, width, height));
   }
 
   panels_.push_back(panel);

[jennb, 2011/12/05 21:20:10]

Add DCHECK before this line that expansion state is EXPANDED.

 }
 
 int PanelStrip::GetMaxPanelWidth() const {
   return static_cast<int>(display_area_.width() * kPanelMaxWidthFactor);
 }
 
 int PanelStrip::GetMaxPanelHeight() const {
   return display_area_.height();
 }
 
@@ skipping 488 matching lines @@
 
   // Start from the bottom to avoid reshuffling.
   for (Panels::reverse_iterator iter = panels_copy.rbegin();
        iter != panels_copy.rend(); ++iter)
     (*iter)->Close();
 }
 
 bool PanelStrip::is_dragging_panel() const {
   return dragging_panel_index_ != kInvalidPanelIndex;
 }