Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 8801027: Always run Flush completion callbacks in Graphics2D. (Closed)

Created:
9 years ago by brettw
Modified:
9 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Always run Flush completion callbacks in Graphics2D. This fixes a leak because the completion callbacks were not getting run on resource destruction. This leaves the calling code waiting for the callbacks with leaked data associated with the callback. This patch just always runs the callbacks with PP_ERROR_ABORTED. I tweaked the callback code to use the (newer than the original code) "run and clear" completion callback macro which also cleans up the code a little. BUG=106402 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113954

Patch Set 1 #

Patch Set 2 : Fix compile #

Patch Set 3 : Really fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -29 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 1 2 3 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years ago (2011-12-05 22:03:32 UTC) #1
yzshen1
9 years ago (2011-12-05 22:09:47 UTC) #2
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698