Always run Flush completion callbacks in Graphics2D.

webkit/plugins/ppapi/ppb_graphics_2d_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPB_GRAPHICS_2D_IMPL_H_
 #define WEBKIT_PLUGINS_PPAPI_PPB_GRAPHICS_2D_IMPL_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 20 matching lines @@
                             public ::ppapi::thunk::PPB_Graphics2D_API {
  public:
   virtual ~PPB_Graphics2D_Impl();
 
   static PP_Resource Create(PP_Instance instance,
                             const PP_Size& size,
                             PP_Bool is_always_opaque);
 
   bool is_always_opaque() const { return is_always_opaque_; }
 
+  // Resource overrides.
   virtual ::ppapi::thunk::PPB_Graphics2D_API* AsPPB_Graphics2D_API();
-
-  // Resource override.
-  virtual PPB_Graphics2D_Impl* AsPPB_Graphics2D_Impl();
+  virtual void LastPluginRefWasDeleted() OVERRIDE;
 
   // PPB_Graphics2D functions.
-  virtual PP_Bool Describe(PP_Size* size, PP_Bool* is_always_opaque);
+  virtual PP_Bool Describe(PP_Size* size, PP_Bool* is_always_opaque) OVERRIDE;
   virtual void PaintImageData(PP_Resource image_data,
                               const PP_Point* top_left,
-                              const PP_Rect* src_rect);
-  virtual void Scroll(const PP_Rect* clip_rect, const PP_Point* amount);
-  virtual void ReplaceContents(PP_Resource image_data);
-  virtual int32_t Flush(PP_CompletionCallback callback);
+                              const PP_Rect* src_rect) OVERRIDE;
+  virtual void Scroll(const PP_Rect* clip_rect,
+                      const PP_Point* amount) OVERRIDE;
+  virtual void ReplaceContents(PP_Resource image_data) OVERRIDE;
+  virtual int32_t Flush(PP_CompletionCallback callback) OVERRIDE;
 
   bool ReadImageData(PP_Resource image, const PP_Point* top_left);
 
   // Assciates this device with the given plugin instance. You can pass NULL to
   // clear the existing device. Returns true on success. In this case, a
   // repaint of the page will also be scheduled. Failure means that the device
   // is already bound to a different instance, and nothing will happen.
   bool BindToInstance(PluginInstance* new_instance);
 
   // Paints the current backing store to the web page.
@@ skipping 29 matching lines @@
 
     void Set(const PP_CompletionCallback& callback) {
       callback_ = callback;
     }
 
     void Clear() {
       callback_ = PP_MakeCompletionCallback(NULL, 0);
     }
 
     void Execute(int32_t result) {
-      PP_RunCompletionCallback(&callback_, result);
+      PP_RunAndClearCompletionCallback(&callback_, result);
     }
 
    private:
     PP_CompletionCallback callback_;
   };
 
   // Called internally to execute the different queued commands. The
   // parameters to these functions will have already been validated. The last
   // rect argument will be filled by each function with the area affected by
   // the update that requires invalidation. If there were no pixels changed,
@@ skipping 62 matching lines @@
 
   base::WeakPtrFactory<PPB_Graphics2D_Impl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PPB_Graphics2D_Impl);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPB_GRAPHICS_2D_IMPL_H_