Fix detection of default G+ profile picture

Fix detection of default G+ profile picture

Currently we assume that any profile picture URL that contains "AAAAAAAAAAI/AAAAAAAAAAA" represents a default profile picture.

It turns out that this is incorrect. There are valid profile pictures with that URL.

With the OAuth user info API we can simply detect default profile pictures by the existance of the "picture" field in the returned data. Accounts with a default profile picture don't have this field.

BUG=106444
TEST=Compiled and verified that unit tests passed.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113487

[Ivan Korotkov, 2011-12-06 08:51:12]

LGTM

http://codereview.chromium.org/8801023/diff/1/chrome/browser/profiles/profile...
File chrome/browser/profiles/profile_downloader.cc (right):

http://codereview.chromium.org/8801023/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_downloader.cc:189: // There are at least two
pairs of (ID, version) for the default photo:
Please fix this comment to match the code.

[sail, 2011-12-06 18:28:12]

http://codereview.chromium.org/8801023/diff/1/chrome/browser/profiles/profile...
File chrome/browser/profiles/profile_downloader.cc (right):

http://codereview.chromium.org/8801023/diff/1/chrome/browser/profiles/profile...
chrome/browser/profiles/profile_downloader.cc:189: // There are at least two
pairs of (ID, version) for the default photo:
On 2011/12/06 08:51:12, Ivan Korotkov wrote:
> Please fix this comment to match the code.

Done.

[commit-bot: I haz the power, 2011-12-06 18:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8801023/7001

[commit-bot: I haz the power, 2011-12-07 19:26:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8801023/7001

[commit-bot: I haz the power, 2011-12-07 20:43:18]

Try job failure for 8801023-7001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-07 21:16:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8801023/7001

[commit-bot: I haz the power, 2011-12-07 22:34:51]

Change committed as 113487