chrome/browser/profiles/profile_downloader_unittest.cc - Issue 8801023: Fix detection of default G+ profile picture

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/profiles/profile_downloader_unittest.cc

Issue 8801023: Fix detection of default G+ profile picture (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/profiles/profile_downloader.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/profiles/profile_downloader.h"	5 #include "chrome/browser/profiles/profile_downloader.h"

6	6

7 #include "base/utf_string_conversions.h"	7 #include "base/utf_string_conversions.h"

8 #include "testing/gtest/include/gtest/gtest.h"	8 #include "testing/gtest/include/gtest/gtest.h"

9	9

10 namespace {	10 namespace {

(...skipping 72 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83 // Data with an invalid URL.	83 // Data with an invalid URL.

84 VerifyWithNameAndURL( "", "invalid url", "", false);	84 VerifyWithNameAndURL( "", "invalid url", "", false);

85 }	85 }

86	86

87 TEST_F(ProfileDownloaderTest, DefaultURL) {	87 TEST_F(ProfileDownloaderTest, DefaultURL) {

88 // Empty URL should be default photo	88 // Empty URL should be default photo

89 EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(""));	89 EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(""));

90 // Picasa default photo	90 // Picasa default photo

91 EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(	91 EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(

92 "https://example.com/-4/AAAAAAAAAAA/AAAAAAAAAAE/G/s64-c/photo.jpg"));	92 "https://example.com/-4/AAAAAAAAAAA/AAAAAAAAAAE/G/s64-c/photo.jpg"));

93 // G+ default photo	93 // Not default G+ photo

94 EXPECT_TRUE(ProfileDownloader::IsDefaultProfileImageURL(	94 EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(

95 "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAAAA/G/photo.jpg"));	95 "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAAAA/G/photo.jpg"));

96 // Not default with 6 components	96 // Not default with 6 components

97 EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(	97 EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(

98 "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/photo.jpg"));	98 "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/photo.jpg"));

99 // Not default with 7 components	99 // Not default with 7 components

100 EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(	100 EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL(

101 "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s32-c/photo.jpg"));	101 "https://example.com/-4/AAAAAAAAAAI/AAAAAAAAACQ/Efg/s32-c/photo.jpg"));

102 // Not default with invalid URL	102 // Not default with invalid URL

103 EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL("invalid url"));	103 EXPECT_FALSE(ProfileDownloader::IsDefaultProfileImageURL("invalid url"));

104 }	104 }

OLD	NEW