Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8800011: Use Textfield's view ID instead of Location bar's view id (Closed)

Created:
9 years ago by oshima
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, kkania, penghuang+watch_chromium.org, robertshield, Paweł Hajdan Jr., James Su
Visibility:
Public.

Description

Use Textfield's view ID instead of Location bar's view id in interactive ui tests because aura is pure views and has no native view. BUG=71144 TEST=more tests in interactive_ui_tests passes on aura Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113309

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Patch Set 4 : ifdef #

Patch Set 5 : sync #

Patch Set 6 : linux fix #

Patch Set 7 : mac fix #

Patch Set 8 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -45 lines) Patch
M chrome/browser/browser_focus_uitest.cc View 1 2 3 4 18 chunks +28 lines, -20 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/view_id_util_browsertest.mm View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/view_id_util_browsertest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 7 chunks +16 lines, -11 lines 0 comments Download
M chrome/browser/ui/view_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 2 7 chunks +26 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
9 years ago (2011-12-05 19:39:37 UTC) #1
sky
LGTM
9 years ago (2011-12-05 21:34:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8800011/3005
9 years ago (2011-12-06 03:10:31 UTC) #3
commit-bot: I haz the power
Try job failure for 8800011-3005 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-06 03:49:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8800011/10001
9 years ago (2011-12-06 04:31:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8800011/15001
9 years ago (2011-12-06 22:51:15 UTC) #6
commit-bot: I haz the power
Can't apply patch for file chrome/browser/automation/ui_controls_aurax11.cc. While running patch -p1 --forward --force; patching file chrome/browser/automation/ui_controls_aurax11.cc ...
9 years ago (2011-12-06 22:51:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8800011/18001
9 years ago (2011-12-06 23:24:26 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-07 00:54:54 UTC) #9 
Change committed as 113309

Powered by Google App Engine
This is Rietveld 408576698