Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 8800011: Use Textfield's view ID instead of Location bar's view id (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/bookmarks/bookmark_model.h" 8 #include "chrome/browser/bookmarks/bookmark_model.h"
9 #include "chrome/browser/bookmarks/bookmark_utils.h" 9 #include "chrome/browser/bookmarks/bookmark_utils.h"
10 #include "chrome/browser/download/download_shelf.h" 10 #include "chrome/browser/download/download_shelf.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 bookmark_utils::AddIfNotBookmarked( 66 bookmark_utils::AddIfNotBookmarked(
67 bookmark_model, GURL(chrome::kAboutBlankURL), ASCIIToUTF16("about")); 67 bookmark_model, GURL(chrome::kAboutBlankURL), ASCIIToUTF16("about"));
68 } 68 }
69 69
70 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) { 70 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
71 // Mac implementation does not support following ids yet. 71 // Mac implementation does not support following ids yet.
72 if (i == VIEW_ID_STAR_BUTTON || 72 if (i == VIEW_ID_STAR_BUTTON ||
73 i == VIEW_ID_AUTOCOMPLETE || 73 i == VIEW_ID_AUTOCOMPLETE ||
74 i == VIEW_ID_CONTENTS_SPLIT || 74 i == VIEW_ID_CONTENTS_SPLIT ||
75 i == VIEW_ID_SIDE_BAR_SPLIT || 75 i == VIEW_ID_SIDE_BAR_SPLIT ||
76 i == VIEW_ID_FEEDBACK_BUTTON) { 76 i == VIEW_ID_FEEDBACK_BUTTON ||
77 i == VIEW_ID_OMNIBOX) {
77 continue; 78 continue;
78 } 79 }
79 80
80 CheckViewID(static_cast<ViewID>(i), true); 81 CheckViewID(static_cast<ViewID>(i), true);
81 } 82 }
82 83
83 CheckViewID(VIEW_ID_TAB, true); 84 CheckViewID(VIEW_ID_TAB, true);
84 CheckViewID(VIEW_ID_TAB_STRIP, true); 85 CheckViewID(VIEW_ID_TAB_STRIP, true);
85 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false); 86 CheckViewID(VIEW_ID_PREDEFINED_COUNT, false);
86 } 87 }
(...skipping 25 matching lines...) Expand all
112 CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), true); 113 CheckViewID(static_cast<ViewID>(VIEW_ID_TAB_0 + i), true);
113 // VIEW_ID_TAB_LAST should always be available. 114 // VIEW_ID_TAB_LAST should always be available.
114 CheckViewID(VIEW_ID_TAB_LAST, true); 115 CheckViewID(VIEW_ID_TAB_LAST, true);
115 } 116 }
116 117
117 // Open the 11th tab. 118 // Open the 11th tab.
118 browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(), 119 browser()->OpenURL(GURL(chrome::kAboutBlankURL), GURL(),
119 NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED); 120 NEW_BACKGROUND_TAB, content::PAGE_TRANSITION_TYPED);
120 CheckViewID(VIEW_ID_TAB_LAST, true); 121 CheckViewID(VIEW_ID_TAB_LAST, true);
121 } 122 }
OLDNEW
« no previous file with comments | « chrome/browser/browser_keyevents_browsertest.cc ('k') | chrome/browser/ui/gtk/view_id_util_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698