Support chrome-extension:// scheme in URLPattern.

chrome/common/extensions/url_pattern.h

Index: chrome/common/extensions/url_pattern.h
diff --git a/chrome/common/extensions/url_pattern.h b/chrome/common/extensions/url_pattern.h
index b9d039d9d3a4638b9b3206e640e93e752edf8b94..b9dc0e55cec8492fcb868d458d32a82d4f0327e3 100644
--- a/chrome/common/extensions/url_pattern.h
+++ b/chrome/common/extensions/url_pattern.h
@@ -15,7 +15,8 @@ class GURL;
 // subset of URL syntax:
 //
 // <url-pattern> := <scheme>://<host><port><path> | '<all_urls>'
-// <scheme> := '*' | 'http' | 'https' | 'file' | 'ftp' | 'chrome'
+// <scheme> := '*' | 'http' | 'https' | 'file' | 'ftp' | 'chrome' |
+//             'chrome-extension' | 'filesystem'
 // <host> := '*' | '*.' <anychar except '/' and '*'>+
 // <port> := [':' ('*' | <port number between 0 and 65535>)]
 // <path> := '/' <any chars>
@@ -90,12 +91,15 @@ class URLPattern {
     SCHEME_FILE       = 1 << 2,
     SCHEME_FTP        = 1 << 3,
     SCHEME_CHROMEUI   = 1 << 4,
-    SCHEME_FILESYSTEM = 1 << 5,
+    SCHEME_EXTENSION  = 1 << 5,
+    SCHEME_FILESYSTEM = 1 << 6,
     // SCHEME_ALL will match every scheme, including chrome://, chrome-
     // extension://, about:, etc. Because this has lots of security
-    // implications, third-party extensions should never be able to get access
-    // to URL patterns initialized this way. It should only be used for internal
-    // Chrome code.
+    // implications, third-party extensions should usually not be able to get
+    // access to URL patterns initialized this way. If there is a reason
+    // for violating this general rule, document why this it safe.
+
+    // !!! SCHEME_ALL SHOULD ONLY BE USED FOR INTERNAL CHROME CODE !!!

[Aaron Boodman, 2011/12/09 16:28:25]

This last sentence seems to conflict with the above paragraph.

How about this:

- put a line break before the beginning of the "SCHEME_ALL will match..."
comment to visually break it up.
- remove this "!!! SCHEME_ALL..." comment
- Add "IMPORTANT! " to the beginning of the comment above.

[battre, 2011/12/09 17:07:51]

Done.

     SCHEME_ALL      = -1,
   };