Support chrome-extension:// scheme in URLPattern.

chrome/common/extensions/url_pattern.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef CHROME_COMMON_EXTENSIONS_URL_PATTERN_H_
 #define CHROME_COMMON_EXTENSIONS_URL_PATTERN_H_
 #pragma once
 
 #include <functional>
 #include <string>
 #include <vector>
 
 class GURL;
 
 // A pattern that can be used to match URLs. A URLPattern is a very restricted
 // subset of URL syntax:
 //
 // <url-pattern> := <scheme>://<host><port><path> | '<all_urls>'
-// <scheme> := '*' | 'http' | 'https' | 'file' | 'ftp' | 'chrome'
+// <scheme> := '*' | 'http' | 'https' | 'file' | 'ftp' | 'chrome' |
+//             'chrome-extension' | 'filesystem'
 // <host> := '*' | '*.' <anychar except '/' and '*'>+
 // <port> := [':' ('*' | <port number between 0 and 65535>)]
 // <path> := '/' <any chars>
 //
 // * Host is not used when the scheme is 'file'.
 // * The port is only used if the pattern is parsed with the USE_PORTS option.
 //   If the patterns is parsed with the ERROR_ON_PORTS option, the port is not
 //   allowed, and the resulting pattern matches any port. If it is parsed with
 //   the IGNORE_PORTS option, the port (including colon) is kept as part of the
 //   host to maintain backwards compatibility with previous versions, which
@@ skipping 54 matching lines @@
 class URLPattern {
  public:
   // A collection of scheme bitmasks for use with valid_schemes.
   enum SchemeMasks {
     SCHEME_NONE       = 0,
     SCHEME_HTTP       = 1 << 0,
     SCHEME_HTTPS      = 1 << 1,
     SCHEME_FILE       = 1 << 2,
     SCHEME_FTP        = 1 << 3,
     SCHEME_CHROMEUI   = 1 << 4,
-    SCHEME_FILESYSTEM = 1 << 5,
+    SCHEME_EXTENSION  = 1 << 5,
+    SCHEME_FILESYSTEM = 1 << 6,
     // SCHEME_ALL will match every scheme, including chrome://, chrome-
     // extension://, about:, etc. Because this has lots of security
-    // implications, third-party extensions should never be able to get access
-    // to URL patterns initialized this way. It should only be used for internal
-    // Chrome code.
+    // implications, third-party extensions should usually not be able to get
+    // access to URL patterns initialized this way. If there is a reason
+    // for violating this general rule, document why this it safe.
+
+    // !!! SCHEME_ALL SHOULD ONLY BE USED FOR INTERNAL CHROME CODE !!!

[Aaron Boodman, 2011/12/09 16:28:25]

This last sentence seems to conflict with the above paragraph.

How about this:

- put a line break before the beginning of the "SCHEME_ALL will match..."
comment to visually break it up.
- remove this "!!! SCHEME_ALL..." comment
- Add "IMPORTANT! " to the beginning of the comment above.

[battre, 2011/12/09 17:07:51]

Done.

     SCHEME_ALL      = -1,
   };
 
   // Options for URLPattern::Parse().
   enum ParseOption {
     ERROR_ON_PORTS,
     IGNORE_PORTS,
     USE_PORTS,
   };
 
@@ skipping 174 matching lines @@
   // MatchPattern() function.
   std::string path_escaped_;
 
   // A string representing this URLPattern.
   mutable std::string spec_;
 };
 
 typedef std::vector<URLPattern> URLPatternList;
 
 #endif  // CHROME_COMMON_EXTENSIONS_URL_PATTERN_H_