Issue 8799005: Revert 112965 - Support mozc suggest window on ChromeOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8799005: Revert 112965 - Support mozc suggest window on ChromeOS. (Closed)

Created:
9 years ago by Yusuke Sato

Modified:
9 years ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, Paweł Hajdan Jr., stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 112965 - Support mozc suggest window on ChromeOS. Ordinal IME shows candidate window under the cursor, but Mozc should show "suggest window"(same view but different location) and it's location is sent by mozc-engine. BUG=chromium-os:21356 TEST=manually confirmed it works fine and no conflict with other CJK engine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112452 Review URL: http://codereview.chromium.org/8505051 TBR=nona@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112971

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -277 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window.cc	View	4 chunks	+3 lines, -48 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc	View	3 chunks	+0 lines, -212 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_ui_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/ibus_ui_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method.gyp	View	1 chunk	+83 lines, -0 lines	0 comments	Download
A +	chrome/browser/chromeos/input_method/litify_proto_file.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages