Support mozc suggest window on ChromeOS.

Support mozc suggest window on ChromeOS.

Ordinal IME shows candidate window under the cursor, but Mozc should show
"suggest window"(same view but different location) and it's location is sent
by mozc-engine.

BUG=chromium-os:21356
TEST=manually confirmed it works fine and no conflict with other CJK engine.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112452

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112965

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113158

[horo, 2011-11-14 04:55:34]

On 2011/11/11 05:28:18, nona1 wrote:

[horo, 2011-11-14 04:56:03]

http://codereview.chromium.org/8505051/diff/6001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method.gyp (right):

http://codereview.chromium.org/8505051/diff/6001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method.gyp:76: 'action_name':
'mozc_commands_local_patch',
Is this action in "'target_name': 'litify_mozc_proto_files'" ?

[Seigo Nonaka, 2011-11-14 05:59:37]

http://codereview.chromium.org/8505051/diff/6001/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/input_method.gyp (right):

http://codereview.chromium.org/8505051/diff/6001/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/input_method.gyp:76: 'action_name':
'mozc_commands_local_patch',
On 2011/11/14 04:56:03, horo wrote:
> Is this action in "'target_name': 'litify_mozc_proto_files'" ?
As the offline talk, I decide to apply patch via temporary file.

[Seigo Nonaka, 2011-11-15 04:34:13]

I will add unit test for this change but it need bit large change.
So I will split CL.
Thank you.

[Hiro Komatsu, 2011-11-15 08:50:19]

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:581: // This location
is used by mozc window rendereing, The mozc-engine have two
typo: the mozc-engine has

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:583: // ordinal look-up
table). The location of these two windows is different
locations / are?

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1099: if
(old_table.mozc_candidates.SerializeToString(&old_serialized_msg)) {
Please make sure if this is your intention.

[Seigo Nonaka, 2011-11-15 11:59:21]

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:581: // This location
is used by mozc window rendereing, The mozc-engine have two
On 2011/11/15 08:50:20, komatsu wrote:
> typo: the mozc-engine has

Done.

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:583: // ordinal look-up
table). The location of these two windows is different
On 2011/11/15 08:50:20, komatsu wrote:
> locations / are?

Done.

http://codereview.chromium.org/8505051/diff/11001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1099: if
(old_table.mozc_candidates.SerializeToString(&old_serialized_msg)) {
On 2011/11/15 08:50:20, komatsu wrote:
> Please make sure if this is your intention.
Sorry this logic is wrong. If old protobuf is wrong, it should be ignored.
(empty string will be ignored at the last equation)

[Hiro Komatsu, 2011-11-16 02:15:57]

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1100: if
(new_table.mozc_candidates.SerializeToString(&new_serialized_msg)) {
Isn't this condition inverted?

Is it possible to write some unittests?

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1391: // location and
cursor location, because mozc-engine does not concern about
concern -> consider?

Is it possible to make mozc-engine consider multi-line composition?

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1392: // multi-line
composition,
The last comma should be period.  (, -> .).

[Seigo Nonaka, 2011-11-16 08:48:11]

This is just response for reviewer's comment.

I will add unit test after submitting http://codereview.chromium.org/8573035/ 

Thank you.

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1100: if
(new_table.mozc_candidates.SerializeToString(&new_serialized_msg)) {
On 2011/11/16 02:15:57, komatsu wrote:
> Isn't this condition inverted?
> 
> Is it possible to write some unittests?
Yes we need precise unit test. So before implement this CL, I will submit
http://codereview.chromium.org/8573035/ .

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1391: // location and
cursor location, because mozc-engine does not concern about
As talked offline, we decide to implement this workaround into candidate window,
the main reason is that mozc-server implementation is problematic when caret
located at the left most.

On 2011/11/16 02:15:57, komatsu wrote:
> concern -> consider?
> 
> Is it possible to make mozc-engine consider multi-line composition?

http://codereview.chromium.org/8505051/diff/16001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:1392: // multi-line
composition,
On 2011/11/16 02:15:57, komatsu wrote:
> The last comma should be period.  (, -> .).

Done.

[Hiro Komatsu, 2011-11-17 08:25:39]

lgtm

[Seigo Nonaka, 2011-11-18 03:46:29]

On 2011/11/17 08:25:39, komatsu wrote:
> lgtm

Sorry for reviewers, I found one big problem with this patch, I will fix and
re-upload soon.
So, if you are reviewing, please stop and wait until my notification.

[Seigo Nonaka, 2011-11-18 04:50:05]

I change my mind to fix an issue by Mozc-engine side.

Let me clarify the problem.
Reproducing process.
1. Open http://www.google.co.jp
2. Enable Japanese IME
3. Enter some character. like 'a'

Expected: show suggest window just under composition text which is located at
the search box.

Actual: Show middle of page.

This bug is not only for Chrome OS but also I can reproduce on Mac OS X.
So I will fix this issue on mozc-engine side.

I will make an issue on crosbug.com but I will fix as soon as possible.

On 2011/11/18 03:46:29, nona1 wrote:
> On 2011/11/17 08:25:39, komatsu wrote:
> > lgtm
> 
> Sorry for reviewers, I found one big problem with this patch, I will fix and
> re-upload soon.
> So, if you are reviewing, please stop and wait until my notification.

[Seigo Nonaka, 2011-11-18 06:51:36]

Dear yusukes,

Could you review and could you test on trybot?

Thank you.

[Yusuke Sato, 2011-11-18 08:21:56]

Adding a .diff file to the Chrome tree looks very weird to me. Can you move the
diff file and litify_proto_file.py to third_party/mozc/ and generate patched
proto files under third_party/mozc/?

You might have to write an additional gyp file for third_party/mozc/, but I
would like to keep chrome main tree clean as much as possible.


On 2011/11/18 06:51:36, nona1 wrote:
> Dear yusukes,
> 
> Could you review and could you test on trybot?
> 
> Thank you.

[Seigo Nonaka, 2011-11-30 10:58:55]

Sorry for late response,
Move commands.proto generation code to mozc repository.

Please review again, thank you.

[Yusuke Sato, 2011-11-30 13:38:20]

Thanks! The CL looks much cleaner than before. Mostly style comments:

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:943: std::string
old_serialized_msg;
nit: move these two variables to L.952.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:946: if
(!old_table.mozc_candidates.IsInitialized()) {
if (!old.. ||
    !new..) {
  return true;
}

would be more consistent with other code.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:982: // Stores mozc
specific window location.
nit: Store

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:985:
mozc::commands::Candidates::CARET) {
nit: what's are possible values of window_location()? switch-case might be
better?

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view.h (right):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:184: gfx::Rect
window_location_for_mozc_engine_;
should we explicitly use the term mozc here? can't we just use something like
suggestion_window_location_?

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:188: bool
is_mozc_window_;
'mozc window' is too ambiguous to me. I prefer something like
is_suggestion_window_location_available_.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc
(right):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:7:
#include <string>
nit: space between line 7&8

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:176: //
This test verifies the process of judging update lookup-table or not with
I couldn't parse this sentence..

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:194: //
State chagne from non-Mozc candidate to Mozc candidate.
be consistent: Mozc or mozc.

You're using the latter in candidate_window_view.cc/h.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method.gyp (left):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method.gyp:54:
'litify_proto_file.py',
I think we can remove the script from the Chrome tree.

[Seigo Nonaka, 2011-12-01 07:10:01]

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window.cc (right):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:943: std::string
old_serialized_msg;
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> nit: move these two variables to L.952.

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:946: if
(!old_table.mozc_candidates.IsInitialized()) {
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> if (!old.. ||
>     !new..) {
>   return true;
> }
> 
> would be more consistent with other code.

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:982: // Stores mozc
specific window location.
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> nit: Store

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window.cc:985:
mozc::commands::Candidates::CARET) {
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> nit: what's are possible values of window_location()? switch-case might be
> better?
I change my mind to use mozc specific location only for suggest window. So we
should deal with window_location only the case of that it is COMPOSITION.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view.h (right):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:184: gfx::Rect
window_location_for_mozc_engine_;
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> should we explicitly use the term mozc here? can't we just use something like
> suggestion_window_location_?

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:188: bool
is_mozc_window_;
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> 'mozc window' is too ambiguous to me. I prefer something like
> is_suggestion_window_location_available_.
> 

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc
(right):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:7:
#include <string>
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> nit: space between line 7&8

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:176: //
This test verifies the process of judging update lookup-table or not with
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> I couldn't parse this sentence..

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:194: //
State chagne from non-Mozc candidate to Mozc candidate.
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> be consistent: Mozc or mozc.
> 
> You're using the latter in candidate_window_view.cc/h.

Done.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method.gyp (left):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method.gyp:54:
'litify_proto_file.py',
On 2011/11/30 13:38:20, Yusuke Sato wrote:
> I think we can remove the script from the Chrome tree.
Hmm I think we cannot because "ibus_inputmethods.h" is still depended by
ibus_controller.cc

[Yusuke Sato, 2011-12-01 07:45:28]

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method.gyp (left):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method.gyp:54:
'litify_proto_file.py',
I mean, "please remove litify_proto_file.py from the Chrome SVN repository."

On 2011/12/01 07:10:01, nona1 wrote:
> On 2011/11/30 13:38:20, Yusuke Sato wrote:
> > I think we can remove the script from the Chrome tree.
> Hmm I think we cannot because "ibus_inputmethods.h" is still depended by
> ibus_controller.cc

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc
(right):

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:14:
namespace {
nit: space between line 14 and 15

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:60: }
vertical space

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:203:
mozc::commands::Candidates::CARET,
not sure but you mean COMPOSITION?

[falken, 2011-12-01 07:48:54]

Drive by review

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view.h (right):

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:182: // compostion
text. In case of ibus-mozc, suggestion window location is
I would say something like "The suggestion window should be aligned with the
composition text as opposed to the cursor"

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:185: //
is_suggestion_window_avaiable is true.
Nits: fix misspellings rendereing, compostion, avaiable.  I would say "when"
instead "in the case of"

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:188: bool
is_suggestion_window_location_avaiable_;
avaiable -> available

[Seigo Nonaka, 2011-12-01 08:11:48]

Thanks Matt for your review!

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view.h (right):

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:182: // compostion
text. In case of ibus-mozc, suggestion window location is
On 2011/12/01 07:48:55, falken wrote:
> I would say something like "The suggestion window should be aligned with the
> composition text as opposed to the cursor"

Done.

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:185: //
is_suggestion_window_avaiable is true.
On 2011/12/01 07:48:55, falken wrote:
> Nits: fix misspellings rendereing, compostion, avaiable.  I would say "when"
> instead "in the case of"

Done.

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view.h:188: bool
is_suggestion_window_location_avaiable_;
On 2011/12/01 07:48:55, falken wrote:
> avaiable -> available

Done.

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc
(right):

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:14:
namespace {
On 2011/12/01 07:45:28, Yusuke Sato wrote:
> nit: space between line 14 and 15

Done.

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:60: }
On 2011/12/01 07:45:28, Yusuke Sato wrote:
> vertical space

Done.

http://codereview.chromium.org/8505051/diff/48001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/candidate_window_view_unittest.cc:203:
mozc::commands::Candidates::CARET,
On 2011/12/01 07:45:28, Yusuke Sato wrote:
> not sure but you mean COMPOSITION?

Done.

[Seigo Nonaka, 2011-12-01 08:32:53]

Sorry I missed one comment and sorry my misunderstanding.

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method.gyp (left):

http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method.gyp:54:
'litify_proto_file.py',
On 2011/12/01 07:45:28, Yusuke Sato wrote:
> I mean, "please remove litify_proto_file.py from the Chrome SVN repository."
> 
> On 2011/12/01 07:10:01, nona1 wrote:
> > On 2011/11/30 13:38:20, Yusuke Sato wrote:
> > > I think we can remove the script from the Chrome tree.
> > Hmm I think we cannot because "ibus_inputmethods.h" is still depended by
> > ibus_controller.cc
> 

Ah, I'm sorry, I misunderstand and I missed this comment.
I re-upload.

[Yusuke Sato, 2011-12-01 08:33:55]

LGTM

On 2011/12/01 08:32:53, nona1 wrote:
> Sorry I missed one comment and sorry my misunderstanding.
> 
>
http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
> File chrome/browser/chromeos/input_method/input_method.gyp (left):
> 
>
http://codereview.chromium.org/8505051/diff/40001/chrome/browser/chromeos/inp...
> chrome/browser/chromeos/input_method/input_method.gyp:54:
> 'litify_proto_file.py',
> On 2011/12/01 07:45:28, Yusuke Sato wrote:
> > I mean, "please remove litify_proto_file.py from the Chrome SVN repository."
> > 
> > On 2011/12/01 07:10:01, nona1 wrote:
> > > On 2011/11/30 13:38:20, Yusuke Sato wrote:
> > > > I think we can remove the script from the Chrome tree.
> > > Hmm I think we cannot because "ibus_inputmethods.h" is still depended by
> > > ibus_controller.cc
> > 
> 
> Ah, I'm sorry, I misunderstand and I missed this comment.
> I re-upload.

[commit-bot: I haz the power, 2011-12-01 11:16:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/8505051/53001

[commit-bot: I haz the power, 2011-12-01 12:23:16]

Change committed as 112452

[Yusuke Sato, 2011-12-05 02:26:36]

http://codereview.chromium.org/8505051/diff/59011/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/ibus_ui_controller.h (right):

http://codereview.chromium.org/8505051/diff/59011/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/ibus_ui_controller.h:18: #include
"session/candidates_lite.pb.h"
could you let me know why the old way didn't work?

[Seigo Nonaka, 2011-12-05 03:09:47]

http://codereview.chromium.org/8505051/diff/59011/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/ibus_ui_controller.h (right):

http://codereview.chromium.org/8505051/diff/59011/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/ibus_ui_controller.h:18: #include
"session/candidates_lite.pb.h"
On 2011/12/05 02:26:36, Yusuke Sato wrote:
> could you let me know why the old way didn't work?

At first, I'm sorry I misunderstand the build break reason and waste your time.
I thought the build-break reason as wrong include path, but now, I find I was
wrong(I found try bot set a correct include path).

So, I have no idea for the build break now.
I will investigate again.
(I wonder if this CL works fine, I believe the old cl also work.)

Thank you.

[Seigo Nonaka, 2011-12-05 09:09:00]

Dear reviewers,

Thanks for shiino-san, I could find the reason of build break. So could you
review this CL again? The most code is same as before except mozc svn revision.

Thank you

Seigo

[Yusuke Sato, 2011-12-05 09:15:53]

lgtm

On 2011/12/05 09:09:00, nona1 wrote:
> Dear reviewers,
> 
> Thanks for shiino-san, I could find the reason of build break. So could you
> review this CL again? The most code is same as before except mozc svn
revision.
> 
> Thank you
> 
> Seigo

[commit-bot: I haz the power, 2011-12-05 09:16:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/8505051/63003

[commit-bot: I haz the power, 2011-12-05 10:34:21]

Change committed as 112965

[Yusuke Sato, 2011-12-06 03:53:22]

nona:
You should at least use linux_chromeos, linux_chromeos_clang,
linux_chromeos_aura, and linux_chromeos_valgrind bots for this CL.

[commit-bot: I haz the power, 2011-12-06 05:57:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/8505051/68001

[commit-bot: I haz the power, 2011-12-06 07:47:11]

Change committed as 113158