Make SpdyFrame::size a constant instead of a static method so gcc can optimize the call away.

Make SpdyFrame::size a constant instead of a static method so gcc can optimize the call away.

Manual changes to spdy_protocol.h and spdy_framer.cc, rest of the CL generated by
running:
  perl -pi -e "s/SpdyFrame::size\(\)/SpdyFrame::kHeaderSize/" $(git grep -l SpdyFrame::size)

This is the same as the google-internal CL 25917366 and 25938381

BUG=94125
TEST=none
TBR=willchan

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112929

[Nico, 2011-12-04 05:10:29]

I'll fix the 80 cols when they're fixed internally :-/

[commit-bot: I haz the power, 2011-12-04 05:10:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8790015/1

[commit-bot: I haz the power, 2011-12-04 05:10:50]

Presubmit check for 8790015-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  net/spdy/spdy_framer.cc, line 924, 84 chars \
  net/spdy/spdy_framer.cc, line 1299, 83 chars \
  net/spdy/spdy_framer.cc, line 1333, 82 chars \
  net/spdy/spdy_framer.cc, line 1373, 83 chars \
  net/spdy/spdy_framer.cc, line 1405, 84 chars

[commit-bot: I haz the power, 2011-12-04 05:35:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8790015/3001

[commit-bot: I haz the power, 2011-12-04 05:40:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8790015/2002

[commit-bot: I haz the power, 2011-12-04 06:00:28]

Try job failure for 8790015-2002 (retry) on win_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-04 06:02:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8790015/31

[willchan no longer on Chromium, 2011-12-04 06:57:26]

LGTM

On Sat, Dec 3, 2011 at 9:10 PM, <thakis@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> I'll fix the 80 cols when they're fixed internally :-/
>
> Description:
> Make SpdyFrame::size a constant instead of a static method so gcc can
> optimize
> the call away.
>
> Manual changes to gfe/spdy/spdy_protocol.h only, rest of the CL generated
> by
> running:
>  perl -pi -e "s/SpdyFrame::size\(\)/**SpdyFrame::kHeaderSize/" $(git grep
> -l
> SpdyFrame::size)
>
> This is the same as the google-internal CL 25917366
>
> BUG=94125
> TEST=none
> TBR=willchan
>
>
> Please review this at
http://codereview.chromium.**org/8790015/<http://codereview.chromium.org/8790...
>
> SVN Base:
http://git.chromium.org/git/**chromium.git@trunk<http://git.chromium.org/git/...
>
> Affected files:
>  M net/spdy/spdy_framer.cc
>  M net/spdy/spdy_framer_test.cc
>  M net/spdy/spdy_protocol.h
>  M net/spdy/spdy_protocol_test.cc
>  M net/spdy/spdy_session.h
>  M net/spdy/spdy_session.cc
>  M net/spdy/spdy_test_util.cc
>  M net/tools/flip_server/**constants.h
>  M net/tools/flip_server/spdy_**interface.cc
>
>
>

[commit-bot: I haz the power, 2011-12-04 07:22:50]

Change committed as 112929