Make SpdyFrame::size a constant instead of a static method so gcc can optimize the call away.

net/spdy/spdy_protocol.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains some protocol structures for use with Spdy.
 
 #ifndef NET_SPDY_SPDY_PROTOCOL_H_
 #define NET_SPDY_SPDY_PROTOCOL_H_
 #pragma once
 
@@ skipping 365 matching lines @@
     DCHECK_EQ(0u, (length & ~kLengthMask));
     length = htonl(length & kLengthMask);
     frame_->flags_length_.length_ = flags() | length;
   }
 
   bool is_control_frame() const {
     return (ntohs(frame_->control_.version_) & kControlFlagMask) ==
         kControlFlagMask;
   }
 
-  // Returns the size of the SpdyFrameBlock structure.
+  // The size of the SpdyFrameBlock structure.
   // Every SpdyFrame* class has a static size() method for accessing
   // the size of the data structure which will be sent over the wire.
   // Note:  this is not the same as sizeof(SpdyFrame).
-  static size_t size() { return sizeof(struct SpdyFrameBlock); }
+  enum { kHeaderSize = sizeof(struct SpdyFrameBlock) };
 
  protected:
   SpdyFrameBlock* frame_;
 
  private:
   bool owns_buffer_;
   DISALLOW_COPY_AND_ASSIGN(SpdyFrame);
 };
 
 // A Data Frame.
@@ skipping 10 matching lines @@
   // Note that setting the stream id sets the control bit to false.
   // As stream id should always be set, this means the control bit
   // should always be set correctly.
   void set_stream_id(SpdyStreamId id) {
     DCHECK_EQ(0u, (id & ~kStreamIdMask));
     frame_->data_.stream_id_ = htonl(id & kStreamIdMask);
   }
 
   // Returns the size of the SpdyFrameBlock structure.
   // Note: this is not the size of the SpdyDataFrame class.
-  static size_t size() { return SpdyFrame::size(); }
+  static size_t size() { return SpdyFrame::kHeaderSize; }
 
   const char* payload() const {
     return reinterpret_cast<const char*>(frame_) + size();
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SpdyDataFrame);
 };
 
 // A Control Frame.
@@ skipping 83 matching lines @@
   void set_associated_stream_id(SpdyStreamId id) {
     mutable_block()->associated_stream_id_ = htonl(id & kStreamIdMask);
   }
 
   SpdyPriority priority() const {
     return (block()->priority_ & kPriorityMask) >> 6;
   }
 
   // The number of bytes in the header block beyond the frame header length.
   int header_block_len() const {
-    return length() - (size() - SpdyFrame::size());
+    return length() - (size() - SpdyFrame::kHeaderSize);
   }
 
   const char* header_block() const {
     return reinterpret_cast<const char*>(block()) + size();
   }
 
   // Returns the size of the SpdySynStreamControlFrameBlock structure.
   // Note: this is not the size of the SpdySynStreamControlFrame class.
   static size_t size() { return sizeof(SpdySynStreamControlFrameBlock); }
 
@@ skipping 16 matching lines @@
 
   SpdyStreamId stream_id() const {
     return ntohl(block()->stream_id_) & kStreamIdMask;
   }
 
   void set_stream_id(SpdyStreamId id) {
     mutable_block()->stream_id_ = htonl(id & kStreamIdMask);
   }
 
   int header_block_len() const {
-    return length() - (size() - SpdyFrame::size());
+    return length() - (size() - SpdyFrame::kHeaderSize);
   }
 
   const char* header_block() const {
     return reinterpret_cast<const char*>(block()) + size();
   }
 
   // Returns the size of the SpdySynReplyControlFrameBlock structure.
   // Note: this is not the size of the SpdySynReplyControlFrame class.
   static size_t size() { return sizeof(SpdySynReplyControlFrameBlock); }
 
@@ skipping 56 matching lines @@
 
   uint32 num_entries() const {
     return ntohl(block()->num_entries_);
   }
 
   void set_num_entries(int val) {
     mutable_block()->num_entries_ = htonl(val);
   }
 
   int header_block_len() const {
-    return length() - (size() - SpdyFrame::size());
+    return length() - (size() - SpdyFrame::kHeaderSize);
   }
 
   const char* header_block() const {
     return reinterpret_cast<const char*>(block()) + size();
   }
 
   // Returns the size of the SpdySettingsControlFrameBlock structure.
   // Note: this is not the size of the SpdySettingsControlFrameBlock class.
   static size_t size() { return sizeof(SpdySettingsControlFrameBlock); }
 
@@ skipping 77 matching lines @@
   SpdyStreamId stream_id() const {
     return ntohl(block()->stream_id_) & kStreamIdMask;
   }
 
   void set_stream_id(SpdyStreamId id) {
     mutable_block()->stream_id_ = htonl(id & kStreamIdMask);
   }
 
   // The number of bytes in the header block beyond the frame header length.
   int header_block_len() const {
-    return length() - (size() - SpdyFrame::size());
+    return length() - (size() - SpdyFrame::kHeaderSize);
   }
 
   const char* header_block() const {
     return reinterpret_cast<const char*>(block()) + size();
   }
 
   // Returns the size of the SpdyHeadersControlFrameBlock structure.
   // Note: this is not the size of the SpdyHeadersControlFrame class.
   static size_t size() { return sizeof(SpdyHeadersControlFrameBlock); }
 
@@ skipping 41 matching lines @@
   struct SpdyWindowUpdateControlFrameBlock* mutable_block() {
     return static_cast<SpdyWindowUpdateControlFrameBlock*>(frame_);
   }
 
   DISALLOW_COPY_AND_ASSIGN(SpdyWindowUpdateControlFrame);
 };
 
 }  // namespace spdy
 
 #endif  // NET_SPDY_SPDY_PROTOCOL_H_