Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 8790001: Revert 112770 - Prevent a crash in the first run search engine selector. (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 112770 - Prevent a crash in the first run search engine selector. It is possible to try and close the window now before the TemplateURLService is loaded. In this case we will not have a fallback search engine to select by default. So we will just reject attempts to close the window in this circumstance until it is loaded and a fallback choice has been set. It should be an edge case. http://crbug.com/106078 TEST=unit test Review URL: http://codereview.chromium.org/8771018 TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -78 lines) Patch
M chrome/browser/ui/views/first_run_search_engine_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view_unittest.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/widget/widget_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Goodger (Google)
9 years ago (2011-12-02 22:06:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698