Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 8771018: Prevent a crash in the first run search engine selector. (Closed)

Created:
9 years ago by Ben Goodger (Google)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Paweł Hajdan Jr., ben+watch_chromium.org
Visibility:
Public.

Description

Reland 112770, but with test disabled. Prevent a crash in the first run search engine selector. It is possible to try and close the window now before the TemplateURLService is loaded. In this case we will not have a fallback search engine to select by default. So we will just reject attempts to close the window in this circumstance until it is loaded and a fallback choice has been set. It should be an edge case. http://crbug.com/106078 TEST=unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113149

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -5 lines) Patch
M chrome/browser/ui/views/first_run_search_engine_view.h View 1 2 3 4 5 6 7 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 2 3 4 5 6 7 4 chunks +27 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view_unittest.cc View 1 2 3 4 5 6 7 2 chunks +58 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ben Goodger (Google)
9 years ago (2011-12-01 22:21:34 UTC) #1
sky
LGTM
9 years ago (2011-12-01 22:55:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8771018/3016
9 years ago (2011-12-02 17:27:35 UTC) #3
commit-bot: I haz the power
Try job failure for 8771018-3016 (retry) on win_rel for step "browser_tests". It's a second try, ...
9 years ago (2011-12-02 19:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8771018/8001
9 years ago (2011-12-02 23:08:24 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-03 03:52:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8771018/8001
9 years ago (2011-12-03 04:59:45 UTC) #7
commit-bot: I haz the power
Try job failure for 8771018-8001 (retry) on win_rel for step "browser_tests". It's a second try, ...
9 years ago (2011-12-03 06:59:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8771018/17001
9 years ago (2011-12-06 03:25:43 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-06 07:34:37 UTC) #10
Change committed as 113149

Powered by Google App Engine
This is Rietveld 408576698