Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 8789005: Simulate a user gesture in Fullscreen test so it can run on bots. (Closed)

Created:
9 years ago by bbudge
Modified:
9 years ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Simulate a user gesture in Fullscreen test so it can run on bots. BUG=NONE TEST=ui_tests, --gtest_filter=PPAPITest.Fullscreen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113684

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : Simulate a user gesture in Fullscreen test so it can run on bots. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +14 lines, -13 lines 0 comments Download
M ppapi/tests/test_fullscreen.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/tests/test_fullscreen.cc View 1 2 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bbudge
9 years ago (2011-12-03 00:09:15 UTC) #1
brettw
lgtm http://codereview.chromium.org/8789005/diff/1/ppapi/tests/test_fullscreen.cc File ppapi/tests/test_fullscreen.cc (right): http://codereview.chromium.org/8789005/diff/1/ppapi/tests/test_fullscreen.cc#newcode146 ppapi/tests/test_fullscreen.cc:146: instance_, Style nit: these should all be indented ...
9 years ago (2011-12-04 01:19:05 UTC) #2
bbudge
Added ppapi_uitest.cc to turn on Fullscreen test in the "in-process" case. http://codereview.chromium.org/8789005/diff/1/ppapi/tests/test_fullscreen.cc File ppapi/tests/test_fullscreen.cc (right): ...
9 years ago (2011-12-07 19:19:55 UTC) #3
bbudge
+sky for ppapi_uitests.cc
9 years ago (2011-12-07 20:36:37 UTC) #4
sky
LGTM
9 years ago (2011-12-07 22:14:07 UTC) #5
bbudge
Need to disable on Mac for the time being as the test is flaky, even ...
9 years ago (2011-12-08 19:05:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/8789005/16001
9 years ago (2011-12-08 20:30:53 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-08 22:54:27 UTC) #8
Change committed as 113684

Powered by Google App Engine
This is Rietveld 408576698