Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: chrome/test/ui/ppapi_uitest.cc

Issue 8789005: Simulate a user gesture in Fullscreen test so it can run on bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Simulate a user gesture in Fullscreen test so it can run on bots. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/tests/test_fullscreen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ppapi_uitest.cc
===================================================================
--- chrome/test/ui/ppapi_uitest.cc (revision 113618)
+++ chrome/test/ui/ppapi_uitest.cc (working copy)
@@ -511,20 +511,21 @@
TEST_F(OutOfProcessPPAPITest, MAYBE_FlashFullscreen) {
RunTestViaHTTP("FlashFullscreen");
}
-// New implementation only honors fullscreen requests within a context of
-// a user gesture. Since we do not yet have an infrastructure for testing
-// those under ppapi_tests, the tests below time out when run automtically.
-// To test the code, run them manually following the directions here:
-// www.chromium.org/developers/design-documents/pepper-plugin-implementation
-// and click on the plugin area (gray square) to force fullscreen mode and
-// get the test unstuck.
-TEST_F(PPAPITest, DISABLED_Fullscreen) {
- RunTestViaHTTP("Fullscreen");
-}
-TEST_F(OutOfProcessPPAPITest, DISABLED_Fullscreen) {
- RunTestViaHTTP("Fullscreen");
-}
+// Fullscreen test fails on Mac.
+#if defined(OS_MACOSX)
+#define MAYBE_Fullscreen FAILS_Fullscreen
+#else
+#define MAYBE_Fullscreen Fullscreen
+#endif
+
+// TODO(bbudge) Fix fullscreen on Mac.
+TEST_PPAPI_IN_PROCESS_VIA_HTTP(MAYBE_Fullscreen)
+// TODO(bbudge) Will fail until we add an ACK message to extend user gesture.
+TEST_PPAPI_OUT_OF_PROCESS_VIA_HTTP(FAILS_Fullscreen)
+// TODO(bbudge) Enable when PPB_Testing_Dev SimulateInputEvent is proxied.
+TEST_PPAPI_NACL_VIA_HTTP(DISABLED_Fullscreen)
+
TEST_PPAPI_IN_PROCESS(FlashClipboard)
TEST_PPAPI_OUT_OF_PROCESS(FlashClipboard)
« no previous file with comments | « no previous file | ppapi/tests/test_fullscreen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698