Issue 8788009: Revert 112812 - Add xinput1_3.dll redist to final package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8788009: Revert 112812 - Add xinput1_3.dll redist to final package. (Closed)

Created:
9 years ago by Lei Zhang

Modified:
9 years ago

Reviewers:
scottmg1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 112812 - Add xinput1_3.dll redist to final package. Adds XInput redist DLL which is a new dependency of recently added gamepad code, and is required on Win XP. laforge has OK'd the size addition to the final package (~100K). BUG=79050 Review URL: http://codereview.chromium.org/8774023 TBR=scottmg@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112859

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -91 lines)			Patch
M	chrome/installer/mini_installer/chrome.release	View	1 chunk	+60 lines, -61 lines	0 comments	Download
M	chrome/tools/build/win/FILES.cfg	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+0 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

9 years ago (2011-12-03 04:38:57 UTC) #2

http://build.chromium.org/p/chromium/builders/Win/builds/8400

Checking c:\b\build\slave\Win\build\src\build\Release\xinput1_3.dll for
/DYNAMICBASE... FAIL
Checking c:\b\build\slave\Win\build\src\build\Release\xinput1_3.dll for
/NXCOMPAT... FAIL

Expand Messages | Collapse Messages