Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 8774023: Add xinput1_3.dll redist to final package. (Closed)

Created:
9 years ago by scottmg
Modified:
9 years ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, dpranke-watch+content_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add xinput1_3.dll redist to final package. Adds XInput redist DLL which is a new dependency of recently added gamepad code, and is required on Win XP. laforge has OK'd the size addition to the final package (~100K). BUG=79050 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112812 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113274

Patch Set 1 #

Patch Set 2 : move location of extract #

Patch Set 3 : rebase #

Patch Set 4 : try from windows (line endings?) #

Patch Set 5 : fix merge #

Patch Set 6 : lf endings on chrome.release #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -60 lines) Patch
M chrome/installer/mini_installer/chrome.release View 1 2 3 4 5 1 chunk +61 lines, -60 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +6 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
scottmg
The goal is here to get xinput1_3.dll into the final package. Changes modelled on the ...
9 years ago (2011-12-02 01:54:34 UTC) #1
scottmg
9 years ago (2011-12-02 01:55:11 UTC) #2
bradn
LGTM on what you've got, but you'll also want to check all the locations listed ...
9 years ago (2011-12-02 06:08:48 UTC) #3
scottmg
On 2011/12/02 06:08:48, bradn wrote: > LGTM on what you've got, but you'll also want ...
9 years ago (2011-12-02 06:21:23 UTC) #4
scottmg
On 2011/12/02 06:21:23, scottmg wrote: > On 2011/12/02 06:08:48, bradn wrote: > > LGTM on ...
9 years ago (2011-12-02 19:21:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8774023/1001
9 years ago (2011-12-02 19:22:14 UTC) #6
commit-bot: I haz the power
Can't apply patch for file chrome/installer/mini_installer/chrome.release. While running patch -p1 --forward --force; patching file chrome/installer/mini_installer/chrome.release ...
9 years ago (2011-12-02 19:22:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8774023/2005
9 years ago (2011-12-02 19:26:21 UTC) #8
commit-bot: I haz the power
Can't apply patch for file chrome/installer/mini_installer/chrome.release. While running patch -p1 --forward --force; patching file chrome/installer/mini_installer/chrome.release ...
9 years ago (2011-12-02 19:26:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8774023/2007
9 years ago (2011-12-02 19:54:27 UTC) #10
commit-bot: I haz the power
Can't apply patch for file chrome/installer/mini_installer/chrome.release. While running patch -p1 --forward --force; patching file chrome/installer/mini_installer/chrome.release ...
9 years ago (2011-12-02 19:54:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/8774023/8001
9 years ago (2011-12-02 22:02:30 UTC) #12
commit-bot: I haz the power
Can't apply patch for file chrome/installer/mini_installer/chrome.release. While running patch -p1 --forward --force; patching file chrome/installer/mini_installer/chrome.release ...
9 years ago (2011-12-02 22:02:32 UTC) #13
scottmg
9 years ago (2011-12-06 19:11:57 UTC) #14
Landing this again now that the dll exclusion has landed.

Powered by Google App Engine
This is Rietveld 408576698