Issue 8786008: Silently swallow exceptions in extension bindings callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8786008: Silently swallow exceptions in extension bindings callbacks. (Closed)

Created:
9 years ago by Aaron Boodman

Modified:
9 years ago

Reviewers:
Matt Perry

CC:
chromium-reviews, jstritar+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Silently swallow exceptions in extension bindings callbacks. There are better ways to handle this, but I want a really simple patch for merge. BUG=106201 TEST=http://code.google.com/p/chromium/issues/detail?id=100401#c18 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112869

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -9 lines)			Patch
A	chrome/browser/extensions/extension_bindings_apitest.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_v8_context.cc	View	3 chunks	+0 lines, -9 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/bindings/exception_in_handler_should_not_crash/manifest.json	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/bindings/exception_in_handler_should_not_crash/page.html	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages