Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8100)

Unified Diff: chrome/renderer/extensions/chrome_v8_context.cc

Issue 8786008: Silently swallow exceptions in extension bindings callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_v8_context.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index 3e4a709ec273b5c5bb02d84924f7987431138f61..525c51e93d41aee05fba1bf31d85f47952037c8e 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -83,7 +83,6 @@ bool ChromeV8Context::CallChromeHiddenMethod(
v8::Handle<v8::Value>* argv,
v8::Handle<v8::Value>* result) const {
v8::Context::Scope context_scope(v8_context_);
- v8::TryCatch try_catch;
// Look up the function name, which may be a sub-property like
// "Port.dispatchOnMessage" in the hidden global variable.
@@ -97,10 +96,6 @@ bool ChromeV8Context::CallChromeHiddenMethod(
if (!value.IsEmpty() && value->IsObject()) {
value = v8::Local<v8::Object>::Cast(value)->Get(
v8::String::New(components[i].c_str()));
- if (try_catch.HasCaught()) {
- NOTREACHED() << *v8::String::AsciiValue(try_catch.Exception());
- return false;
- }
}
}
@@ -111,10 +106,6 @@ bool ChromeV8Context::CallChromeHiddenMethod(
v8::Handle<v8::Value> result_temp =
v8::Local<v8::Function>::Cast(value)->Call(v8::Object::New(), argc, argv);
- if (try_catch.HasCaught()) {
- NOTREACHED() << *v8::String::AsciiValue(try_catch.Exception());
- return false;
- }
if (result)
*result = result_temp;
return true;

Powered by Google App Engine
This is Rietveld 408576698