Move command line processing out of coordinator

ppapi/native_client/src/trusted/plugin/plugin.cc

Index: ppapi/native_client/src/trusted/plugin/plugin.cc
===================================================================
--- ppapi/native_client/src/trusted/plugin/plugin.cc	(revision 113812)
+++ ppapi/native_client/src/trusted/plugin/plugin.cc	(working copy)
@@ -966,6 +966,7 @@
       RequestNaClManifest(manifest_url);
     }
   }
+  pnacl_.Initialize(this);

[robertm, 2011/12/12 16:23:29]

This is sort of pre-existing.
why is this not done in the constructor?
If there is a good reason, please add a comment
Better yet, make the name more meaningful so that the comment
is not necessary.

[sehr (please use chromium), 2011/12/13 00:12:45]

I have changed how the coordinator is instantiated, and made the initialization
be hidden inside a factory.

 
   // Export a property to allow us to get the last error description.
   AddPropertyGet(GetLastError, "lastError", "s");
@@ -1000,9 +1001,8 @@
   PLUGIN_PRINTF(("Plugin::Plugin (this=%p, pp_instance=%"
                  NACL_PRId32")\n", static_cast<void*>(this), pp_instance));
   NaClSrpcModuleInit();
+  callback_factory_.Initialize(this);
   nexe_downloader_.Initialize(this);
-  pnacl_.Initialize(this);
-  callback_factory_.Initialize(this);
 }