Move command line processing out of coordinator

ppapi/native_client/src/trusted/plugin/plugin.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifdef _MSC_VER
 // Do not warn about use of std::copy with raw pointers.
 #pragma warning(disable : 4996)
 #endif
 
 #include "native_client/src/trusted/plugin/plugin.h"
@@ skipping 948 matching lines @@
         PLUGIN_PRINTF(("Plugin::Init:"
                        " WARNING: 'nacl' property is incorrect. Use 'src'.\n"));
       }
     } else {
       // Issue a GET for the manifest_url.  The manifest file will be parsed to
       // determine the nexe URL.
       // Sets src property to full manifest URL.
       RequestNaClManifest(manifest_url);
     }
   }
+  pnacl_.Initialize(this);

[robertm, 2011/12/12 16:23:29]

This is sort of pre-existing.
why is this not done in the constructor?
If there is a good reason, please add a comment
Better yet, make the name more meaningful so that the comment
is not necessary.

[sehr (please use chromium), 2011/12/13 00:12:45]

I have changed how the coordinator is instantiated, and made the initialization
be hidden inside a factory.

 
   // Export a property to allow us to get the last error description.
   AddPropertyGet(GetLastError, "lastError", "s");
   // Export a property to allow us to get the nexe exit status.
   AddPropertyGet(GetExitStatus, "exitStatus", "i");
 
   PLUGIN_PRINTF(("Plugin::Init (status=%d)\n", status));
   return status;
 }
 
@@ skipping 14 matching lines @@
       enable_dev_interfaces_(false),
       replayDidChangeView(false),
       replayHandleDocumentLoad(false),
       init_time_(0),
       ready_time_(0),
       nexe_size_(0),
       time_of_last_progress_event_(0) {
   PLUGIN_PRINTF(("Plugin::Plugin (this=%p, pp_instance=%"
                  NACL_PRId32")\n", static_cast<void*>(this), pp_instance));
   NaClSrpcModuleInit();
+  callback_factory_.Initialize(this);
   nexe_downloader_.Initialize(this);
-  pnacl_.Initialize(this);
-  callback_factory_.Initialize(this);
 }
 
 
 Plugin::~Plugin() {
   int64_t shutdown_start = NaClGetTimeOfDayMicroseconds();
 
   PLUGIN_PRINTF(("Plugin::~Plugin (this=%p, scriptable_handle=%p)\n",
                  static_cast<void*>(this),
                  static_cast<void*>(scriptable_handle())));
 
@@ skipping 1014 matching lines @@
   std::string scheme = canonicalized.AsString().substr(comps.scheme.begin,
                                                        comps.scheme.len);
   if (scheme == kChromeExtensionUriScheme)
     return SCHEME_CHROME_EXTENSION;
   if (scheme == kDataUriScheme)
     return SCHEME_DATA;
   return SCHEME_OTHER;
 }
 
 }  // namespace plugin